Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONTMERGETHIS] v0.42.2 release train #8916

Closed
wants to merge 22 commits into from
Closed

[DONTMERGETHIS] v0.42.2 release train #8916

wants to merge 22 commits into from

Commits on Mar 9, 2021

  1. fixed broken links, typos (#8783) (#8823) 

    * fixed broken links, typos

* Update docs/ibc/overview.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* Update docs/intro/sdk-app-architecture.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

* Update docs/building-modules/simulator.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

Co-authored-by: chrly <chrly@chrlys-MacBook-Pro.local>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Marko <markobaricevic3778@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 24ed401)

Co-authored-by: Charly <16255463+charleenfei@users.noreply.github.com>
    @mergify @charleenfei
    mergify[bot] and charleenfei authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    98e122f View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. add trust to macOS Keychain for calling apps by default (#8826) (#8835) 

    This commit automatically trusts the calling application with its data,
avoiding all the annoying keychain popups that appears when dealing with
keys (list, add...).

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
(cherry picked from commit d761f08)

Co-authored-by: Gianguido Sora <gsora@users.noreply.github.com>
    @mergify @gsora
    mergify[bot] and gsora authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    339484a View commit details
    Browse the repository at this point in the history

  2. store/cachekv: use typed types/kv.List instead of container/list.List (… 

    …#8811) (#8817)

Reduces CPU burn by using a typed List to avoid the expensive type
assertions from using an interface. This is the only option for now
until Go makes generics generally available.

The change brings time spent on the time assertion cummulatively to:
    580ms down from 6.88s

Explanation:
The type assertions were showing up heavily in profiles:
* Before this commit
```shell
Total: 42.18s
ROUTINE ======================== github.com/cosmos/cosmos-sdk/store/cachekv.newMemIterator
in /Users/emmanuelodeke/go/src/github.com/cosmos/cosmos-sdk/store/cachekv/memiterator.go
    14.01s     18.87s (flat, cum) 44.74% of Total
         .          .     17:	items      []*kv.Pair
         .          .     18:	ascending  bool
         .          .     19:}
         .          .     20:
         .          .     21:func newMemIterator(start, end []byte, items *list.List, ascending bool) *memIterator {
         .      620ms     22:	itemsInDomain := make([]*kv.Pair, 0, items.Len())
         .          .     23:
         .          .     24:	var entered bool
         .          .     25:
     510ms      870ms     26:	for e := items.Front(); e != nil; e = e.Next() {
     6.85s      6.88s     27:		item := e.Value.(*kv.Pair)
     5.71s      8.19s     28:		if !dbm.IsKeyInDomain(item.Key, start, end) {
     120ms      120ms     29:			if entered {
         .          .     30:				break
         .          .     31:			}
         .          .     32:
         .          .     33:			continue
         .          .     34:		}
         .          .     35:
     820ms      980ms     36:		itemsInDomain = append(itemsInDomain, item)
         .          .     37:		entered = true
         .          .     38:	}
         .          .     39:
         .      1.21s     40:	return &memIterator{
         .          .     41:		start:     start,
         .          .     42:		end:       end,
         .          .     43:		items:     itemsInDomain,
         .          .     44:		ascending: ascending,
         .          .     45:	}
```

and given that the list only uses that type, it is only right to lift the
code from container/list.List, and only modify Element.Value's type.

For emphasis, the code is basically just a retrofit of
container/list/list.go but with a typing, and we'll keep it as is
until perhaps Go1.17 or Go1.18 or when everyone uses Go1.17+ after
generics have landed.

* After this commit
```shell
Total: 45.25s
ROUTINE ======================== github.com/cosmos/cosmos-sdk/store/cachekv.newMemIterator
in /Users/emmanuelodeke/go/src/github.com/cosmos/cosmos-sdk/store/cachekv/memiterator.go
     4.84s      6.77s (flat, cum) 14.96% of Total
         .          .     16:	items      []*kv.Pair
         .          .     17:	ascending  bool
         .          .     18:}
         .          .     19:
         .          .     20:func newMemIterator(start, end []byte, items *kv.List, ascending bool) *memIterator {
         .      330ms     21:	itemsInDomain := make([]*kv.Pair, 0, items.Len())
         .          .     22:
         .          .     23:	var entered bool
         .          .     24:
      60ms      160ms     25:	for e := items.Front(); e != nil; e = e.Next() {
     580ms      580ms     26:		item := e.Value
     3.68s      4.78s     27:		if !dbm.IsKeyInDomain(item.Key, start, end) {
      80ms       80ms     28:			if entered {
         .          .     29:				break
         .          .     30:			}
         .          .     31:
         .          .     32:			continue
         .          .     33:		}
         .          .     34:
     440ms      580ms     35:		itemsInDomain = append(itemsInDomain, item)
         .          .     36:		entered = true
         .          .     37:	}
         .          .     38:
         .      260ms     39:	return &memIterator{
         .          .     40:		start:     start,
         .          .     41:		end:       end,
         .          .     42:		items:     itemsInDomain,
         .          .     43:		ascending: ascending,
         .          .     44:	}
```

Fixes #8810

(cherry picked from commit c2d5b24)

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
    @mergify @odeke-em
    mergify[bot] and odeke-em authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    1391ea6 View commit details
    Browse the repository at this point in the history

  3. fixes: permalinks for docs (#8838) (#8846) 

    * fixed broken links, typos

* Update docs/ibc/overview.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* Update docs/intro/sdk-app-architecture.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

* Update docs/building-modules/simulator.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

* build(deps): bump JamesIves/github-pages-deploy-action from 4.0.0 to 4.1.0 (#8792)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/JamesIves/github-pages-deploy-action) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/JamesIves/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@4.0.0...3dbacc7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix multisig account pubkeys migration (#8794)

closes: #8776

* Update mergify (#8784)

* Update mergify

Prep for the v0.42 release series.

* retire v0.41, the hub can upgrade to v0.42 smoothly

* perf change (#8796)

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Supply by denom Migrations (#8780)

* Add back supply proto

* Add migration for supply

* Fix lint

* Update x/bank/spec/01_state.md

* Fix test

* Proto gen

* Update x/bank/spec/01_state.md

* Make proto gen

Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>

* fix make protoc error (#8799)

* reduce gas costs by 10x for transient store operations (#8790)

* reduce gas costs by 10x for transient store operations

* fix TestTransientGasConfig for ReadCostFlat

* added changelog entry

* fix changelog

* fix changelog

Co-authored-by: Alessio Treglia <alessio@tendermint.com>

* x/gov: fix NormalizeProposalType() return values (#8808)

Closes: #8806

* store/cachekv: use typed types/kv.List instead of container/list.List (#8811)

Reduces CPU burn by using a typed List to avoid the expensive type
assertions from using an interface. This is the only option for now
until Go makes generics generally available.

The change brings time spent on the time assertion cummulatively to:
    580ms down from 6.88s

Explanation:
The type assertions were showing up heavily in profiles:
* Before this commit
```shell
Total: 42.18s
ROUTINE ======================== github.com/cosmos/cosmos-sdk/store/cachekv.newMemIterator
in /Users/emmanuelodeke/go/src/github.com/cosmos/cosmos-sdk/store/cachekv/memiterator.go
    14.01s     18.87s (flat, cum) 44.74% of Total
         .          .     17:	items      []*kv.Pair
         .          .     18:	ascending  bool
         .          .     19:}
         .          .     20:
         .          .     21:func newMemIterator(start, end []byte, items *list.List, ascending bool) *memIterator {
         .      620ms     22:	itemsInDomain := make([]*kv.Pair, 0, items.Len())
         .          .     23:
         .          .     24:	var entered bool
         .          .     25:
     510ms      870ms     26:	for e := items.Front(); e != nil; e = e.Next() {
     6.85s      6.88s     27:		item := e.Value.(*kv.Pair)
     5.71s      8.19s     28:		if !dbm.IsKeyInDomain(item.Key, start, end) {
     120ms      120ms     29:			if entered {
         .          .     30:				break
         .          .     31:			}
         .          .     32:
         .          .     33:			continue
         .          .     34:		}
         .          .     35:
     820ms      980ms     36:		itemsInDomain = append(itemsInDomain, item)
         .          .     37:		entered = true
         .          .     38:	}
         .          .     39:
         .      1.21s     40:	return &memIterator{
         .          .     41:		start:     start,
         .          .     42:		end:       end,
         .          .     43:		items:     itemsInDomain,
         .          .     44:		ascending: ascending,
         .          .     45:	}
```

and given that the list only uses that type, it is only right to lift the
code from container/list.List, and only modify Element.Value's type.

For emphasis, the code is basically just a retrofit of
container/list/list.go but with a typing, and we'll keep it as is
until perhaps Go1.17 or Go1.18 or when everyone uses Go1.17+ after
generics have landed.

* After this commit
```shell
Total: 45.25s
ROUTINE ======================== github.com/cosmos/cosmos-sdk/store/cachekv.newMemIterator
in /Users/emmanuelodeke/go/src/github.com/cosmos/cosmos-sdk/store/cachekv/memiterator.go
     4.84s      6.77s (flat, cum) 14.96% of Total
         .          .     16:	items      []*kv.Pair
         .          .     17:	ascending  bool
         .          .     18:}
         .          .     19:
         .          .     20:func newMemIterator(start, end []byte, items *kv.List, ascending bool) *memIterator {
         .      330ms     21:	itemsInDomain := make([]*kv.Pair, 0, items.Len())
         .          .     22:
         .          .     23:	var entered bool
         .          .     24:
      60ms      160ms     25:	for e := items.Front(); e != nil; e = e.Next() {
     580ms      580ms     26:		item := e.Value
     3.68s      4.78s     27:		if !dbm.IsKeyInDomain(item.Key, start, end) {
      80ms       80ms     28:			if entered {
         .          .     29:				break
         .          .     30:			}
         .          .     31:
         .          .     32:			continue
         .          .     33:		}
         .          .     34:
     440ms      580ms     35:		itemsInDomain = append(itemsInDomain, item)
         .          .     36:		entered = true
         .          .     37:	}
         .          .     38:
         .      260ms     39:	return &memIterator{
         .          .     40:		start:     start,
         .          .     41:		end:       end,
         .          .     42:		items:     itemsInDomain,
         .          .     43:		ascending: ascending,
         .          .     44:	}
```

Fixes #8810

* Move all migration scripts to v043 (#8814)

* Move all migration scripts to v043

* Fix permaling

* Fix test

* Fix test again

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* permalinks

Co-authored-by: chrly <chrly@chrlys-MacBook-Pro.local>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Marko <markobaricevic3778@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Albert Chon <albert@injectiveprotocol.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
(cherry picked from commit 55fc465)

Co-authored-by: Charly <charly@interchain.berlin>
    @mergify @charleenfei
    mergify[bot] and charleenfei authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    c9f36a8 View commit details
    Browse the repository at this point in the history

  4. Merge pull request from GHSA-mvm6-gfm2-89xj 

    Co-authored-by: Alessio Treglia <alessio@tendermint.com>
    @alexanderbez @robert-zaremba
    2 people authored and robert-zaremba committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    3de3752 View commit details
    Browse the repository at this point in the history

  5. v0.42.1 Changelog update (#8851)

    @robert-zaremba
    robert-zaremba authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    2181455 View commit details
    Browse the repository at this point in the history

  6. Security/ghsa mvm6 gfm2 89xj (#8852) 

    * Merge pull request from GHSA-mvm6-gfm2-89xj

Co-authored-by: Alessio Treglia <alessio@tendermint.com>

* v0.42.1 Changelog update (#8851)

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
    @robert-zaremba @alexanderbez
    3 people authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    2ffe530 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. keyring: update documentation (#8839) (#8858) 

    * keyring: update documentation

* Update docs/run-node/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/run-node/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 3954c24)

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
    @mergify
    mergify[bot] and Alessio Treglia authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2196c9b View commit details
    Browse the repository at this point in the history

  2. Merge tag 'v0.42.1' into release/v0.42.x 

    Release v0.42.1
    Alessio Treglia committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    7ea2760 View commit details
    Browse the repository at this point in the history

  3. Fix SendToModuleAccountTest (bp #8857) (#8860) 

    * Fix SendToModuleAccountTest (#8857)

(cherry picked from commit 280ee4f)

Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
    @mergify @jgimeno
    3 people authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c6462e6 View commit details
    Browse the repository at this point in the history

  4. all: skip noisy/faulty benchmarks + add b.ReportAllocs for every benc… 

    …hmark (bp #8856) (#8859)

* all: skip noisy/faulty benchmarks + add b.ReportAllocs for every benchmark (#8856)

* Skips very noisy benchmarks that end up running only for b.N=1 because
their entire time is spent in setup, and varying parameters doesn't change
much given that the number of stores is what dominates the expense. To
ensure we can provide reliable benchmarks, progressively for the project,
skip these until there is a proper re-work of what the benchmarks need to do

* Previously sub-benchmarks: b.Run(...) did not b.ReportAllocs() due to a faulty
assumption that invoking b.ReportAllocs() at the top would be inherited by
all sub-benchmarks. This change fixes that

Fixes #8779
Fixes #8855

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit b9f3db1)

* Remove stray code that got pulled in by mergify but not essential

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
    @mergify @odeke-em
    3 people authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1d98b2a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. add --output-document to multisign-batch (#8873) (#8877) 

    Closes: #8870

Co-authored-by: SaReN <sahithnarahari@gmail.com>
(cherry picked from commit 5f71e93)

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
    @mergify
    mergify[bot] and Alessio Treglia authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e23c0ce View commit details
    Browse the repository at this point in the history

  2. Fix multisig LegacyAminoPubKey Amino marshaling (bp #8841) (#8878) 

    (cherry picked from commit d4d27e1)

closes: #8776

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
    @mergify @amaury1093 @anilcse
    4 people authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    1e17860 View commit details
    Browse the repository at this point in the history

  3. docs: update dropdown v0.41 → v0.42 (#8888)

    @lovincyrus
    lovincyrus authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    eb09ee1 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Update docs (bp #8751) (#8894) 

    closes: #8750

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 36f68eb)

Co-authored-by: Pash <pashashocky@gmail.com>
Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
    @mergify @pashashocky @amaury1093
    3 people authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    51b163e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. add orderBy parameter to TxsByEvents (bp #8815) (#8883) 

    Closes: #8686

(cherry picked from commit 553aac5)

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: aleem1314 <aleem@vitwit.com>
    @mergify @amaury1093
    @aleem1314 @jgimeno
    6 people authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    177672f View commit details
    Browse the repository at this point in the history

  2. Fix typo (#8905) (#8910) 

    Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 0836361)

Co-authored-by: Hanjun Kim <hallazzang@gmail.com>
    @mergify @hallazzang
    mergify[bot] and hallazzang authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    a619b1d View commit details
    Browse the repository at this point in the history

  3. Docs: Anys Usage, Events & small cleanups (bp #8895) (#8911) 

    Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
(cherry picked from commit 1a4418b)
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @mergify @amaury1093
    4 people authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    16187a8 View commit details
    Browse the repository at this point in the history

  4. update changelog and RELEASE NOTES (#8912) 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
    @amaury1093
    3 people authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    c111c3e View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. add +nobuild flags to all relevant test cases (bp #8934) (#8938) 

    Closes: #8923
(cherry picked from commit 7b09f95)
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
    @mergify
    mergify[bot] and Alessio Treglia authored Mar 19, 2021
    Configuration menu
    Copy the full SHA
    c57f4cb View commit details
    Browse the repository at this point in the history

  2. backport test detection ci fix (#8924) (#8942) 

    cherry-pick 641b13e
    Alessio Treglia authored Mar 19, 2021
    Configuration menu
    Copy the full SHA
    8db5c2b View commit details
    Browse the repository at this point in the history

  3. update changelog

    Alessio Treglia committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    4749feb View commit details
    Browse the repository at this point in the history