Fix for the --home flag #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ag and config.toml file correctly
zmanian
requested review from
alessio,
alexanderbez,
jgimeno and
shahankhatch
as code owners
Codecov Report
@@ Coverage Diff @@
## hub/cosmoshub-4.6 #852 +/- ##
=================================================
Coverage 0.40% 0.40%
=================================================
Files 7 7
Lines 490 490
=================================================
Hits 2 2
Misses 487 487
Partials 1 1 |
alessio
reviewed
May 11, 2021
| @@ -45,7 +45,7 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) { | |||
| WithAccountRetriever(types.AccountRetriever{}). | |||
| WithBroadcastMode(flags.BroadcastBlock). | |||
| WithHomeDir(gaia.DefaultNodeHome). | |||
| WithViper("") // In simapp, we don't use any prefix for env variables. | |||
| WithViper("GAIA") | |||
adizere
approved these changes
May 11, 2021
shahankhatch
pushed a commit
that referenced
this pull request
May 11, 2021
* Adds the necessary setup to the gaia viper root to handle the home flag and config.toml file correctly * Add an environment variable prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
--homeflag in gaia 4.6For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)