Prepare gaia alpha release for cosmoshub-4.6 upgrade #834

shahankhatch · 2021-04-27T01:36:24Z

Closes #829

This branch is for the DEX and the upcoming Hub upgrade

Updates deps to Cosmos SDK v0.43-alpha1 and ibc-go v1.0.0-alpha1

codecov · 2021-04-27T01:39:49Z

Codecov Report

Merging #834 (0101175) into main (8bc3a8f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #834      +/-   ##
========================================
- Coverage   0.41%   0.39%   -0.02%     
========================================
  Files          7       7              
  Lines        483     504      +21     
========================================
  Hits           2       2              
- Misses       480     501      +21     
  Partials       1       1

shahankhatch · 2021-04-27T01:43:16Z

I have two places in the code commented with // TODO: cosmoshub-4.6 where I'm not sure if the right API was used to update breaking changes.

Note that these breaking changes don't look like they were included in the SDK changelog.

* Updates installation, join-mainnet and first start for service provider docs * Modifies service providers doc * Updates Service Providers remote access gaia * Remove validator step from full-node setup * Updates service provider guide rest api documentation * Updates to go v1.16 on gaia v4.2.1 * Changes format on the join-mainnet guide * Updates to go v1.16 and wording in the join-mainnet documentation * Updates CLI commands * Adds more descriptive CLI command output * Adds more account cli details * Adds index with links * Remove transaction signing for now * Adds sentence that default pruning is recommended for most setups * Apply suggestions from code review Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * Use go1.15 * Remove relayer as word for http calls Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Changes version in reproducible-builds * Updates reproducible build example

* Update gaia to go1.16

not intended for use

shahankhatch · 2021-05-05T13:22:10Z

app/pubkey_replacement.go

@@ -68,7 +68,9 @@ func loadKeydataFromFile(clientCtx client.Context, replacementrJSON string, genD

 			toReplaceValConsAddress, _ := val.GetConsAddr()

-			consPubKey, err := sdk.GetPubKeyFromBech32(sdk.Bech32PubKeyTypeConsPub, replacement.ConsensusPubkey)
+			// TODO: cosmoshub-4.6


Disable linter for use of deprecated api

zmanian · 2021-05-09T02:03:10Z

Wouldn't this be gaia 5.0?

colin-axner · 2021-05-10T12:21:18Z

There's a regression in this branch when compared against v4.2.1. The --home flag doesn't work. It only partially applies the new home directory, so some files are placed in the right location and others are placed in .gaia. Came across this bug since relayers use this functionality in there scripts which break with this branch

Verified by installing this and v4.2.1 and running gaia init --home <different director>

Haven't looked into where the bug is exactly

Quickly looking at the diffs, looks like the issue should be in the SDK, but I was unable to reproduce using simd from v0.43.0-alpha1

zmanian · 2021-05-10T20:01:03Z

@colin-axner I have a lead on the root cause for this bug. I ran into it too. It's missing changes in root.go. I'll try have a patch soon after i have get out of back to back calls.

shahankhatch · 2021-05-10T20:30:31Z

Wouldn't this be gaia 5.0?

Thanks, good point. I'll apply this to the codebase.

This branch name is 4.6 for now to note the tentative upgrade month, and that the Cosmos Hub chain id won't be changing.

zmanian · 2021-05-11T02:20:11Z

Here is a fix for the home flag issue.
#852

* Removed unnecessary slash in the link

* Adds the necessary setup to the gaia viper root to handle the home flag and config.toml file correctly * Add an environment variable prefix.

* Completing feegrant module integration * Completing authz module integration and added vesting cli

* Adds the necessary setup to the gaia viper root to handle the home flag and config.toml file correctly * Add an environment variable prefix.

shahankhatch · 2021-05-12T14:48:53Z

Seems like non-deterministic sim is failing with

panic: type_url /cosmos.authz.v1beta1.Msg/GrantAuthorization has not been registered yet. Before calling RegisterService, you must register all interfaces by calling the `RegisterInterfaces` method on module.BasicManager. Each module should call `msgservice.RegisterMsgServiceDesc` inside its `RegisterInterfaces` method with the `_Msg_serviceDesc` generated by proto-gen [recovered]
	panic: type_url /cosmos.authz.v1beta1.Msg/GrantAuthorization has not been registered yet. Before calling RegisterService, you must register all interfaces by calling the `RegisterInterfaces` method on module.BasicManager. Each module should call `msgservice.RegisterMsgServiceDesc` inside its `RegisterInterfaces` method with the `_Msg_serviceDesc` generated by proto-gen

I will look into this.

colin-axner · 2021-05-12T14:57:27Z

Seems like non-deterministic sim is failing with

panic: type_url /cosmos.authz.v1beta1.Msg/GrantAuthorization has not been registered yet. Before calling RegisterService, you must register all interfaces by calling the `RegisterInterfaces` method on module.BasicManager. Each module should call `msgservice.RegisterMsgServiceDesc` inside its `RegisterInterfaces` method with the `_Msg_serviceDesc` generated by proto-gen [recovered]
	panic: type_url /cosmos.authz.v1beta1.Msg/GrantAuthorization has not been registered yet. Before calling RegisterService, you must register all interfaces by calling the `RegisterInterfaces` method on module.BasicManager. Each module should call `msgservice.RegisterMsgServiceDesc` inside its `RegisterInterfaces` method with the `_Msg_serviceDesc` generated by proto-gen

I will look into this.

Maybe try bumping to beta1? I'd expect this to be an error in the SDK, but a lot has changed since their alpha1 release

shahankhatch · 2021-05-12T14:59:33Z

Thanks @colin-axner I suspect it's because feegrant module wasn't included in sim setup within the gaia app. I added it so hopefully that'll do the trick.

shahankhatch · 2021-05-12T23:20:31Z

Apart from adding the code that was missing, I updated to sdk beta1 and ibc-go alpha2, and the sims seem to be running. Thanks @colin-axner for the suggestion!

app/app.go

colin-axner · 2021-06-15T15:12:38Z

The migrate command should be removed or updated. I'm in favor of updating it

I view the plan for this upgrade as the following:

Plan A - x/upgrade + upgrade migrations (probably via cosmovisor)
Plan B - validators use flag unsafe-skip-upgrades
Plan C - before Plan A, validators would have exported genesis. If > 1/3 validators accidentally get corrupt databases due to a failure in Plan A, Plan B may no longer be viable. In such a situation, the chain should restart via the exported genesis

My main concern is validators not doing a back up before upgrade migrations and upgrade migrations failing for some unforeseen reason . Does cosmovisor do backups before restarting? I think Plan C is super rare, but if Plan A and Plan B fail, it'd be a real mess to get the network back up

shahankhatch · 2021-07-06T12:57:20Z

Closing this as the liquidity module has been merged into master through another branch #858

colin-axner · 2021-07-06T14:16:49Z

this branch was unrelated to the liquidity module and was preparation for SDK v0.43. Is there a new branch that will be opened?

Update gaiad deps to Cosmos SDK v0.43-alpha1 and ibc-go v1.0.0-alpha1

c1a41c2

shahankhatch requested review from alessio, alexanderbez, jgimeno and zmanian as code owners April 27, 2021 01:36

Tobias Schwarz and others added 8 commits April 27, 2021 10:22

Changes version in reproducible-builds (#835)

b39e555

* Changes version in reproducible-builds * Updates reproducible build example

Change identifier of long-running sim based on label (#839)

f51d367

Remove file filter for running long-running sim based on label (#840)

85e2676

Remove diff check from github action for long-running sim (#841)

4b9958d

Add compilation prerequisites (#837)

c77cd15

Update gaia build to go1.16 (#838)

09f9d8d

* Update gaia to go1.16

Delete Dockerfile (#844)

7117a91

not intended for use

shahankhatch commented May 5, 2021

View reviewed changes

shahankhatch added 2 commits May 7, 2021 10:58

Removing unused docker action until requirements are defined (#850)

fa96bee

Adding submission and PR guidelines (#849)

ab74ade

Puzanira and others added 2 commits May 11, 2021 04:50

Merge pull request #853

830c0ca

* Removed unnecessary slash in the link

Fix for the --home flag (#852)

986a9a3

* Adds the necessary setup to the gaia viper root to handle the home flag and config.toml file correctly * Add an environment variable prefix.

shahankhatch mentioned this pull request May 11, 2021

cosmoshub-4.6 module integrations #854

Merged

shahankhatch and others added 4 commits May 11, 2021 11:36

cosmoshub-4.6 module integrations (#854)

69ab1d2

* Completing feegrant module integration * Completing authz module integration and added vesting cli

Increment gaia version to v5 (#855)

9c3829d

Update gaiad deps to Cosmos SDK v0.43-alpha1 and ibc-go v1.0.0-alpha1

eb5bb34

Fix for the --home flag (#852)

4e97411

* Adds the necessary setup to the gaia viper root to handle the home flag and config.toml file correctly * Add an environment variable prefix.

shahankhatch added the sim label May 11, 2021

shahankhatch changed the title ~~Update gaiad deps to Cosmos SDK v0.43-alpha1 and ibc-go v1.0.0-alpha1~~ Prepare gaia for alpha release May 11, 2021

shahankhatch changed the title ~~Prepare gaia for alpha release~~ Prepare gaia alpha release for cosmoshub-4.6 upgrade May 11, 2021

Register feegrant module with sim

6a2ce91

aaronc mentioned this pull request May 12, 2021

Upgrade to 0.43-beta1 and integrate x/authz & x/feegrant into stable regen-network/regen-ledger#336

Closed

shahankhatch added sim and removed sim labels May 12, 2021

adizere mentioned this pull request May 12, 2021

Support for Protobuf-based keys informalsystems/hermes#936

Merged

5 tasks

Bumped to sdk beta1 and ibc alpha2

1723fc7

shahankhatch added sim and removed sim labels May 12, 2021

Register authz module with sim module

99c77cd

shahankhatch added sim and removed sim labels May 12, 2021

Register authz module, for real

f04a23f

shahankhatch added sim and removed sim labels May 12, 2021

colin-axner mentioned this pull request May 17, 2021

Gaiad manager informalsystems/hermes#928

Merged

5 tasks

colin-axner reviewed May 17, 2021

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

Updated ibc integration based on ibc migration guide

0101175

colin-axner mentioned this pull request May 20, 2021

Inconsistent setting of genesis supply cosmos/cosmos-sdk#9372

Closed

4 tasks

shahankhatch closed this Jul 6, 2021

tac0turtle deleted the hub/cosmoshub-4.6 branch October 5, 2021 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare gaia alpha release for cosmoshub-4.6 upgrade #834

Prepare gaia alpha release for cosmoshub-4.6 upgrade #834

shahankhatch commented Apr 27, 2021 •

edited

Loading

codecov bot commented Apr 27, 2021 •

edited

Loading

shahankhatch commented Apr 27, 2021 •

edited

Loading

shahankhatch May 5, 2021

zmanian commented May 9, 2021

colin-axner commented May 10, 2021 •

edited

Loading

zmanian commented May 10, 2021

shahankhatch commented May 10, 2021

zmanian commented May 11, 2021

shahankhatch commented May 12, 2021

colin-axner commented May 12, 2021

shahankhatch commented May 12, 2021

shahankhatch commented May 12, 2021

colin-axner commented Jun 15, 2021

shahankhatch commented Jul 6, 2021

colin-axner commented Jul 6, 2021

Prepare gaia alpha release for cosmoshub-4.6 upgrade #834

Prepare gaia alpha release for cosmoshub-4.6 upgrade #834

Conversation

shahankhatch commented Apr 27, 2021 • edited Loading

codecov bot commented Apr 27, 2021 • edited Loading

Codecov Report

shahankhatch commented Apr 27, 2021 • edited Loading

shahankhatch May 5, 2021

Choose a reason for hiding this comment

zmanian commented May 9, 2021

colin-axner commented May 10, 2021 • edited Loading

zmanian commented May 10, 2021

shahankhatch commented May 10, 2021

zmanian commented May 11, 2021

shahankhatch commented May 12, 2021

colin-axner commented May 12, 2021

shahankhatch commented May 12, 2021

shahankhatch commented May 12, 2021

colin-axner commented Jun 15, 2021

shahankhatch commented Jul 6, 2021

colin-axner commented Jul 6, 2021

shahankhatch commented Apr 27, 2021 •

edited

Loading

codecov bot commented Apr 27, 2021 •

edited

Loading

shahankhatch commented Apr 27, 2021 •

edited

Loading

colin-axner commented May 10, 2021 •

edited

Loading