Skip to content

Commit

Permalink
removing solomachine consensus state nil check and test cases (#1895)
Browse files Browse the repository at this point in the history
  • Loading branch information
damiannolan authored Aug 8, 2022
1 parent 9a4ed68 commit 87bae33
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
4 changes: 0 additions & 4 deletions modules/light-clients/06-solomachine/client_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,6 @@ func produceVerificationArgs(
return nil, nil, 0, 0, err
}

if cs.ConsensusState == nil {
return nil, nil, 0, 0, sdkerrors.Wrap(clienttypes.ErrInvalidConsensus, "consensus state cannot be empty")
}

// sequence is encoded in the revision height of height struct
sequence := height.GetRevisionHeight()
latestSequence := cs.GetLatestHeight().GetRevisionHeight()
Expand Down
14 changes: 0 additions & 14 deletions modules/light-clients/06-solomachine/client_state_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -447,13 +447,6 @@ func (suite *SoloMachineTestSuite) TestVerifyMembership() {
},
true,
},
{
"consensus state in client state is nil",
func() {
clientState = solomachine.NewClientState(1, nil, false)
},
false,
},
{
"client state latest height is less than sequence",
func() {
Expand Down Expand Up @@ -665,13 +658,6 @@ func (suite *SoloMachineTestSuite) TestVerifyNonMembership() {
},
true,
},
{
"consensus state in client state is nil",
func() {
clientState = solomachine.NewClientState(1, nil, false)
},
false,
},
{
"client state latest height is less than sequence",
func() {
Expand Down

0 comments on commit 87bae33

Please sign in to comment.