chore: removing solomachine consensus state nil check #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal and
seantking
as code owners
| @@ -231,10 +231,6 @@ func produceVerificationArgs( | |||
| return nil, nil, 0, 0, err | |||
| } | |||
|
|
|||
| if cs.ConsensusState == nil { | |||
| return nil, nil, 0, 0, sdkerrors.Wrap(clienttypes.ErrInvalidConsensus, "consensus state cannot be empty") | |||
There was a problem hiding this comment.
should we panic here or will we just let it panic when we try to use it later on?
There was a problem hiding this comment.
it will panic when we try to use .ConsensusState. I think it is okay to let that happen imo. The panic message gets redacted anyways
seantking
approved these changes
Aug 8, 2022
damiannolan
deleted the
damian/1888-remove-nil-check-solomachine-consensusstate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1888
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes