Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transfer)!: migrate transfer parameters to be self managed #3553

Merged
merged 116 commits into from
May 24, 2023
Merged

feat(transfer)!: migrate transfer parameters to be self managed #3553

merged 116 commits into from
May 24, 2023

Commits on May 3, 2023

  1. added 'UpdateParams' rpc endpoint and its messages to 'tx.proto'

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    20e1c44 View commit details
    Browse the repository at this point in the history

  2. ran 'make proto-gen'

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1658827 View commit details
    Browse the repository at this point in the history

  3. implemented 'sdk.Msg' for 'MsgUpdateParams' in 'types/msgs.go'

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    df392d6 View commit details
    Browse the repository at this point in the history

  4. 'msgs_test.go' updated - todo test tests + create a 'NewMsgUpdatePara… 

    …ms' function and update tests
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    964f97e View commit details
    Browse the repository at this point in the history

  5. added 'NewMsgUpdateParams' function to 'types/msgs.go'

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    369d399 View commit details
    Browse the repository at this point in the history

  6. improved test styling and used helper functions more

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2b0a739 View commit details
    Browse the repository at this point in the history

  7. added boilerplate 'UpdateParams' function to MsgServer - todo impleme… 

    …nt the custom logic
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c8383bb View commit details
    Browse the repository at this point in the history

  8. removed paramtypes and added authority to Keeper struct - todo Keeper… 

    … functions need to be updated
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a53233f View commit details
    Browse the repository at this point in the history

  9. updated Keeper functions - todo add ParamsKey to types + update keepe… 

    …r tests
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    829c8a5 View commit details
    Browse the repository at this point in the history

  10. deleted unneeded keeper/params.go as this should be managed in keeper.go

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5af4e23 View commit details
    Browse the repository at this point in the history

  11. moved params test from params_test to keeper_test as this is where th… 

    …ey should be managed now
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5accc5d View commit details
    Browse the repository at this point in the history

  12. added ParamsKey to 'types/keys.go'

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0a950ef View commit details
    Browse the repository at this point in the history

  13. replaced 'k.GetSendEnabled(ctx)' with 'k.GetParams(ctx).SendEnabled' … 

    …in msg_server
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3bfcbdb View commit details
    Browse the repository at this point in the history

  14. replaced 'k.GetReceiveEnabled(ctx)' with 'k.GetParams(ctx).ReceiveEna… 

    …bled' in 'relay.go'
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6d5bf05 View commit details
    Browse the repository at this point in the history

  15. added 'MsgUpdateParams' to InterfaceRegistry

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    464c385 View commit details
    Browse the repository at this point in the history

  16. implemented 'UpdateParams' in msg_server

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    98be444 View commit details
    Browse the repository at this point in the history

  17. added one more test case to msgs_test for ParamsValidation

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    990e663 View commit details
    Browse the repository at this point in the history

  18. wrote tests for 'TestUpdateParams' rpc handler

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    83c550c View commit details
    Browse the repository at this point in the history

  19. removed params subspace - todo: add subspaces back as legacy for migr… 

    …ations
    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8ab5596 View commit details
    Browse the repository at this point in the history

  20. removed test cases that didn't make sense

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e27637a View commit details
    Browse the repository at this point in the history

  21. fixed the tests here

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    859c0bb View commit details
    Browse the repository at this point in the history

  22. fixed typo in function comment

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    300600a View commit details
    Browse the repository at this point in the history

  23. fixed keeper tests

    @srdtrk
    srdtrk committed May 3, 2023
    Configuration menu
    Copy the full SHA
    838c495 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. merge with main

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    f6df036 View commit details
    Browse the repository at this point in the history

  2. ran 'golangci-lint' on 'transfer/types/...'

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    9dc8bc8 View commit details
    Browse the repository at this point in the history

  3. added validation to SetParams keeper method

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    f07dab2 View commit details
    Browse the repository at this point in the history

  4. handled the case where 'SetParams' returns an error 'InitGenesis'

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    637babc View commit details
    Browse the repository at this point in the history

  5. fix: forgot to check value of '.SetParams' to ensure it is not an error

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    cc3b07e View commit details
    Browse the repository at this point in the history

  6. ran 'gofumpt' on 'transfer/keeper/'

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    ffbd6b2 View commit details
    Browse the repository at this point in the history

  7. split 'types/params.go' into a legacy part

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c244ad2 View commit details
    Browse the repository at this point in the history

  8. created 'exported.go' for migration purposes

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    63788a4 View commit details
    Browse the repository at this point in the history

  9. added migration code to 'keeper/migrations.go'

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    5673df4 View commit details
    Browse the repository at this point in the history

  10. increased module.go version and registered param migration

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    e9317e9 View commit details
    Browse the repository at this point in the history

  11. passed legacySubspace to transfer for migration

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b2018cf View commit details
    Browse the repository at this point in the history

  12. allow tests to compile and pass by passing the subspace to the migrat… 

    …or - todo: add param migration tests
    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    54ef45d View commit details
    Browse the repository at this point in the history

  13. removed unneeded if statement

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    12d93e3 View commit details
    Browse the repository at this point in the history

  14. ran gofumpt

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    0395da8 View commit details
    Browse the repository at this point in the history

  15. added integration tests for successful migration of params

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    027ab9e View commit details
    Browse the repository at this point in the history

  16. fix: forgot to check if '.SetParams' returns an err

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    ba60fc5 View commit details
    Browse the repository at this point in the history

  17. ran gofumpt

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    6ee83a7 View commit details
    Browse the repository at this point in the history

  18. broken: this test is work in progress and will fail

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c93bf8d View commit details
    Browse the repository at this point in the history

  19. uncommented the two lines in test

    @srdtrk
    srdtrk committed May 4, 2023
    Configuration menu
    Copy the full SHA
    ffcbd01 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. fixed an important error on params_legacy.go

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    5d8fcc8 View commit details
    Browse the repository at this point in the history

  2. initialize ParamKeyTable for ibctransfer in app.go now

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    e2c0a65 View commit details
    Browse the repository at this point in the history

  3. finally a working version of the test

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    01637a7 View commit details
    Browse the repository at this point in the history

  4. style changes on the test

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    280bdfa View commit details
    Browse the repository at this point in the history

  5. ran 'gofumpt'

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    1acf716 View commit details
    Browse the repository at this point in the history

  6. moved comment

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    a52f1d0 View commit details
    Browse the repository at this point in the history

  7. updated GetParams function's comment

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    280b25d View commit details
    Browse the repository at this point in the history

  8. updated docs

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    cd5e83a View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin' into serdar/issue#3502-self-man… 

    …age-transfer-params
    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    9cdb411 View commit details
    Browse the repository at this point in the history

  10. e2e: changed x/params query to fallback behavior

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    2efb934 View commit details
    Browse the repository at this point in the history

  11. e2e: changed x/params query to fallback behavior

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    8e22f05 View commit details
    Browse the repository at this point in the history

  12. e2e: dropped the fallback behavior

    @srdtrk
    srdtrk committed May 5, 2023
    Configuration menu
    Copy the full SHA
    222df20 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. e2e: trying to use the new gov proposal v1 to change params

    @srdtrk
    srdtrk committed May 6, 2023
    Configuration menu
    Copy the full SHA
    8825b0d View commit details
    Browse the repository at this point in the history

  2. e2e: created 'isSelfManagingParams' function

    @srdtrk
    srdtrk committed May 6, 2023
    Configuration menu
    Copy the full SHA
    50c8003 View commit details
    Browse the repository at this point in the history

  3. e2e: created fallback behaviour for param update gov proposal

    @srdtrk
    srdtrk committed May 6, 2023
    Configuration menu
    Copy the full SHA
    86dae68 View commit details
    Browse the repository at this point in the history

  4. chore: e2e code cleanup

    @srdtrk
    srdtrk committed May 6, 2023
    Configuration menu
    Copy the full SHA
    b8e6098 View commit details
    Browse the repository at this point in the history

  5. chore: ran 'gofumpt' in e2e

    @srdtrk
    srdtrk committed May 6, 2023
    Configuration menu
    Copy the full SHA
    1b51575 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. style(transfer/test): moved success case to top 

    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    @srdtrk @damiannolan
    srdtrk and damiannolan authored May 16, 2023
    Configuration menu
    Copy the full SHA
    7300d40 View commit details
    Browse the repository at this point in the history

  2. style(transfer/test): replaced request with msg

    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    50ea74f View commit details
    Browse the repository at this point in the history

  3. refactor(transfer): moved MsgUpdateParams' registry to Interface Regi… 

    …stry
    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    383cd9d View commit details
    Browse the repository at this point in the history

  4. style(transfer/test): ran gofumpt

    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a6b1859 View commit details
    Browse the repository at this point in the history

  5. style(transfer): moved UpdateParams function to the bottom of the file

    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0c6fbb7 View commit details
    Browse the repository at this point in the history

  6. imp(transfer): using 'ibcerrors.ErrInvalidAddress' instead of 'govtyp… 

    …es.ErrInvalidSigner'
    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    557f431 View commit details
    Browse the repository at this point in the history

  7. refactor(transfer/test): used ibctesting constants instead of definin… 

    …g my own
    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    18b53f6 View commit details
    Browse the repository at this point in the history

  8. feat(e2e/transfer): using semver to handle gov prop fallback instead … 

    …of queries
    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    296a140 View commit details
    Browse the repository at this point in the history

  9. style(e2e/transfer): renamed 'selfParamFeatureReleases' to 'transferS… 

    …elfParamFeatureReleases'
    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0d5bd67 View commit details
    Browse the repository at this point in the history

  10. merge: merge remote-tracking branch 'origin' into serdar/issue#3502-s… 

    …elf-manage-transfer-params
    @srdtrk
    srdtrk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    bd46565 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. feat(transfer): keeping paramSpace in keeper and removing exported to… 

    … reduce mods to simapp
    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c81bedb View commit details
    Browse the repository at this point in the history

  2. feat(simapp): reduced the modifications to app.go to only one

    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    aa7866d View commit details
    Browse the repository at this point in the history

  3. fix(transfer/test): updated migration tests

    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    51cdced View commit details
    Browse the repository at this point in the history

  4. imp(transfer/test): improved the efficiency and style of the test

    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    40f63e2 View commit details
    Browse the repository at this point in the history

  5. style(transfer): ran gofumpt

    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f560320 View commit details
    Browse the repository at this point in the history

  6. merge: remote-tracking branch 'origin' into serdar/issue#3502-self-ma… 

    …nage-transfer-params
    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8cd90eb View commit details
    Browse the repository at this point in the history

  7. style(transfer): ParamsKey is now stored via a string rather than bytes

    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    cf03c5b View commit details
    Browse the repository at this point in the history

  8. imp(transfer): retired the old validate function, and new one makes m… 

    …ore sense
    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    06cade8 View commit details
    Browse the repository at this point in the history

  9. style(transfer): ran gofumpt

    @srdtrk
    srdtrk committed May 18, 2023
    Configuration menu
    Copy the full SHA
    a33610e View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. refactor(transfer): removed the validate function for params as it cu… 

    …rrently does nothing and reduces codecov
    @srdtrk
    srdtrk committed May 20, 2023
    Configuration menu
    Copy the full SHA
    9beef82 View commit details
    Browse the repository at this point in the history

  2. fix(transfer): refactored to not use validate

    @srdtrk
    srdtrk committed May 20, 2023
    Configuration menu
    Copy the full SHA
    485360e View commit details
    Browse the repository at this point in the history

  3. imp(transfer): GetParams now panics if params are not set

    @srdtrk
    srdtrk committed May 20, 2023
    Configuration menu
    Copy the full SHA
    4dcf47a View commit details
    Browse the repository at this point in the history

  4. imp(transfer/test): added a new test case to test when Params are unset

    @srdtrk
    srdtrk committed May 20, 2023
    Configuration menu
    Copy the full SHA
    e73f8c1 View commit details
    Browse the repository at this point in the history

  5. style(transfer/test): updated the test messages

    @srdtrk
    srdtrk committed May 20, 2023
    Configuration menu
    Copy the full SHA
    3763e9c View commit details
    Browse the repository at this point in the history

  6. merge: remote-tracking branch 'origin' into serdar/issue#3502-self-ma… 

    …nage-transfer-params
    @srdtrk
    srdtrk committed May 20, 2023
    Configuration menu
    Copy the full SHA
    4fef125 View commit details
    Browse the repository at this point in the history

  7. docs(transfer): added tracking issue for removing params_legacy.go

    @srdtrk
    srdtrk committed May 20, 2023
    Configuration menu
    Copy the full SHA
    c8fe227 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. imp(transfer): added a new error type for invalid authority

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d6a0dfb View commit details
    Browse the repository at this point in the history

  2. style(e2e/transfer): fixed typo

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    3ba800d View commit details
    Browse the repository at this point in the history

  3. style(transfer/test): stopped using field names in test case declaration

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    98b8ba3 View commit details
    Browse the repository at this point in the history

  4. style(transfer/test): stopped using field names in test case declaration

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    764bedb View commit details
    Browse the repository at this point in the history

  5. style(transfer/test): renamed test case

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d6496bb View commit details
    Browse the repository at this point in the history

  6. imp(transfer): added more info to the error message

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    6466de8 View commit details
    Browse the repository at this point in the history

  7. style(e2e/transfer): updated ordering of deps

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    4d90658 View commit details
    Browse the repository at this point in the history

  8. imp(transfer/test): reduced the test size

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    0d60d6a View commit details
    Browse the repository at this point in the history

  9. style(transfer): changed the err message for 'ErrInvalidAuthority'

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    7813b39 View commit details
    Browse the repository at this point in the history

  10. imp(transfer): removed ErrInvalidAuthority

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    29b0f93 View commit details
    Browse the repository at this point in the history

  11. style(transfer): using 'len(bz) == 0' instead of 'bz == nil'

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    e5f3960 View commit details
    Browse the repository at this point in the history

  12. style(transfer): removed unneeded comment

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    6de4b5e View commit details
    Browse the repository at this point in the history

  13. merge: remote-tracking branch 'origin' into serdar/issue#3502-self-ma… 

    …nage-transfer-params
    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    948acf8 View commit details
    Browse the repository at this point in the history

  14. imp(transfer): switched back to using 'bz == nil'

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    4c163f0 View commit details
    Browse the repository at this point in the history

  15. revert: '7813b39d7835eec26a3655bcd77587198ae90bea'

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    a336e68 View commit details
    Browse the repository at this point in the history

  16. revert: "style(transfer): changed the err message for 'ErrInvalidAuth… 

    …ority'"

This reverts commit 7813b39.
    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    be96b41 View commit details
    Browse the repository at this point in the history

  17. revert: e5f3960

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    bb83f08 View commit details
    Browse the repository at this point in the history

  18. revert: 4c163f0

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    33807c6 View commit details
    Browse the repository at this point in the history

  19. style(transfer): added code comment

    @srdtrk
    srdtrk committed May 22, 2023
    Configuration menu
    Copy the full SHA
    c672221 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. merge: remote-tracking branch 'origin' into serdar/issue#3502-self-ma… 

    …nage-transfer-params
    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    2b425ce View commit details
    Browse the repository at this point in the history

  2. docs(migrations): added migration docs for changes in app.go

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b63e056 View commit details
    Browse the repository at this point in the history

  3. imp(transfer): improved ValidateBasic err message

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    759c1ae View commit details
    Browse the repository at this point in the history

  4. style(transfer/test): improved the styling of the test

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    db60e4f View commit details
    Browse the repository at this point in the history

  5. style(transfer/test): improved the styling of the test

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3ad8090 View commit details
    Browse the repository at this point in the history

  6. docs(transfer): added godoc for UpdateParams method

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9aaf717 View commit details
    Browse the repository at this point in the history

  7. style(transfer): removed named return arg

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    97c74b5 View commit details
    Browse the repository at this point in the history

  8. merge: remote-tracking branch 'origin' into serdar/issue#3502-self-ma… 

    …nage-transfer-params
    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    18c35c8 View commit details
    Browse the repository at this point in the history

  9. merge: remote-tracking branch 'origin' into serdar/issue#3502-self-ma… 

    …nage-transfer-params
    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    73fadd2 View commit details
    Browse the repository at this point in the history

  10. imp(e2e/transfer): reduced code duplication

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    305dc88 View commit details
    Browse the repository at this point in the history

  11. style(transfer/test): updated test case names

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7d66ac3 View commit details
    Browse the repository at this point in the history

  12. imp(transfer/test): added whitespace test case

    @srdtrk
    srdtrk committed May 24, 2023
    Configuration menu
    Copy the full SHA
    04b2591 View commit details
    Browse the repository at this point in the history