feat(transfer)!: migrate transfer parameters to be self managed #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms' function and update tests
…nt the custom logic
… functions need to be updated
…ey should be managed now
…bled' in 'relay.go'
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
+ Coverage 78.75% 78.79% +0.04%
==========================================
Files 186 186
Lines 12744 12773 +29
==========================================
+ Hits 10036 10064 +28
- Misses 2276 2278 +2
+ Partials 432 431 -1
|
damiannolan
reviewed
May 24, 2023
…nage-transfer-params
damiannolan
approved these changes
May 24, 2023
e2e/tests/transfer/base_test.go
Outdated
Comment on lines
33
to
35
| var transferSelfParamsFeatureReleases = semverutil.FeatureReleases{ | ||
| MajorVersion: "v8", | ||
| } |
There was a problem hiding this comment.
feature release matrices are being grouped together in test values in #3558, just noting this for resolving merge conflicts
9 tasks
…nage-transfer-params
chatton
approved these changes
May 24, 2023
| // Transfer defines an rpc handler method for MsgTransfer. | ||
| func (k Keeper) Transfer(goCtx context.Context, msg *types.MsgTransfer) (*types.MsgTransferResponse, error) { | ||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
|
|
||
| if !k.GetSendEnabled(ctx) { | ||
| if !k.GetParams(ctx).SendEnabled { |
There was a problem hiding this comment.
I think I prefer just accessing the fields directly from params rather than a getter which would include no additional logic. I don't think params needs to be anything more than just a struct of values.
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR:
transferapp now self-manages its parameters.transferapp's parameters.x/params' subspace to thetransferapp's keeper.closes: #3502
addresses: #2010
Changes:
MsgUpdateParams, has been introduced, executed with an authority that is expected to be thex/govmodule account.Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.