feat(transfer)!: migrate transfer parameters to be self managed #3553
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,13 +2,14 @@ package transfer | |
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "cosmossdk.io/math" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| govtypes "github.com/cosmos/cosmos-sdk/x/gov/types" | ||
| paramsproposaltypes "github.com/cosmos/cosmos-sdk/x/params/types/proposal" | ||
| transfertypes "github.com/cosmos/ibc-go/v7/modules/apps/transfer/types" | ||
|
|
||
| "github.com/strangelove-ventures/interchaintest/v7/ibc" | ||
| test "github.com/strangelove-ventures/interchaintest/v7/testutil" | ||
|
|
@@ -17,7 +18,6 @@ import ( | |
| "github.com/cosmos/ibc-go/e2e/semverutil" | ||
| "github.com/cosmos/ibc-go/e2e/testsuite" | ||
| "github.com/cosmos/ibc-go/e2e/testvalues" | ||
| ibctesting "github.com/cosmos/ibc-go/v7/testing" | ||
| ) | ||
|
|
||
|
|
@@ -29,34 +29,25 @@ type TransferTestSuite struct { | |
| testsuite.E2ETestSuite | ||
| } | ||
|
|
||
| // transferSelfParamsFeatureReleases represents the releases the transfer module started managing its own params. | ||
| var transferSelfParamsFeatureReleases = semverutil.FeatureReleases{ | ||
| MajorVersion: "v8", | ||
| } | ||
|
There was a problem hiding this comment. feature release matrices are being grouped together in test values in #3558, just noting this for resolving merge conflicts |
||
|
|
||
| // QueryTransferSendEnabledParam queries the on-chain send enabled param for the transfer module | ||
| func (s *TransferTestSuite) QueryTransferSendEnabledParam(ctx context.Context, chain ibc.Chain) bool { | ||
srdtrk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| queryClient := s.GetChainGRCPClients(chain).TransferQueryClient | ||
| res, err := queryClient.Params(ctx, &transfertypes.QueryParamsRequest{}) | ||
| s.Require().NoError(err) | ||
| return res.Params.SendEnabled | ||
| } | ||
|
|
||
| // QueryTransferReceiveEnabledParam queries the on-chain receive enabled param for the transfer module | ||
| func (s *TransferTestSuite) QueryTransferReceiveEnabledParam(ctx context.Context, chain ibc.Chain) bool { | ||
| queryClient := s.GetChainGRCPClients(chain).TransferQueryClient | ||
| res, err := queryClient.Params(ctx, &transfertypes.QueryParamsRequest{}) | ||
| s.Require().NoError(err) | ||
| return res.Params.ReceiveEnabled | ||
| } | ||
|
|
||
| // TestMsgTransfer_Succeeds_Nonincentivized will test sending successful IBC transfers from chainA to chainB. | ||
|
|
@@ -258,6 +249,13 @@ func (s *TransferTestSuite) TestSendEnabledParam() { | |
| chainBWallet := s.CreateUserOnChainB(ctx, testvalues.StartingTokenAmount) | ||
| chainBAddress := chainBWallet.FormattedAddress() | ||
|
|
||
| chainAVersion := chainA.Config().Images[0].Version | ||
| isSelfManagingParams := transferSelfParamsFeatureReleases.IsSupported(chainAVersion) | ||
|
|
||
| govModuleAddress, err := s.QueryModuleAccountAddress(ctx, govtypes.ModuleName, chainA) | ||
| s.Require().NoError(err) | ||
| s.Require().NotNil(govModuleAddress) | ||
|
|
||
| s.Require().NoError(test.WaitForBlocks(ctx, 1, chainA, chainB), "failed to wait for blocks") | ||
|
|
||
| t.Run("ensure transfer sending is enabled", func(t *testing.T) { | ||
|
|
@@ -271,12 +269,17 @@ func (s *TransferTestSuite) TestSendEnabledParam() { | |
| }) | ||
|
|
||
| t.Run("change send enabled parameter to disabled", func(t *testing.T) { | ||
| if isSelfManagingParams { | ||
srdtrk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| msg := transfertypes.NewMsgUpdateParams(govModuleAddress.String(), transfertypes.NewParams(false, true)) | ||
| s.ExecuteGovProposalV1(ctx, msg, chainA, chainAWallet, 1) | ||
| } else { | ||
| changes := []paramsproposaltypes.ParamChange{ | ||
| paramsproposaltypes.NewParamChange(transfertypes.StoreKey, string(transfertypes.KeySendEnabled), "false"), | ||
| } | ||
|
|
||
| proposal := paramsproposaltypes.NewParameterChangeProposal(ibctesting.Title, ibctesting.Description, changes) | ||
| s.ExecuteGovProposal(ctx, chainA, chainAWallet, proposal) | ||
| } | ||
| }) | ||
|
|
||
| t.Run("ensure transfer params are disabled", func(t *testing.T) { | ||
|
|
@@ -309,6 +312,13 @@ func (s *TransferTestSuite) TestReceiveEnabledParam() { | |
| chainBAddress = chainBWallet.FormattedAddress() | ||
| ) | ||
|
|
||
| chainAVersion := chainA.Config().Images[0].Version | ||
| isSelfManagingParams := transferSelfParamsFeatureReleases.IsSupported(chainAVersion) | ||
|
|
||
| govModuleAddress, err := s.QueryModuleAccountAddress(ctx, govtypes.ModuleName, chainA) | ||
| s.Require().NoError(err) | ||
| s.Require().NotNil(govModuleAddress) | ||
|
|
||
| s.Require().NoError(test.WaitForBlocks(ctx, 1, chainA, chainB), "failed to wait for blocks") | ||
|
|
||
| t.Run("ensure transfer receive is enabled", func(t *testing.T) { | ||
|
|
@@ -350,12 +360,17 @@ func (s *TransferTestSuite) TestReceiveEnabledParam() { | |
| }) | ||
|
|
||
| t.Run("change receive enabled parameter to disabled ", func(t *testing.T) { | ||
| if isSelfManagingParams { | ||
| msg := transfertypes.NewMsgUpdateParams(govModuleAddress.String(), transfertypes.NewParams(false, false)) | ||
| s.ExecuteGovProposalV1(ctx, msg, chainA, chainAWallet, 1) | ||
| } else { | ||
| changes := []paramsproposaltypes.ParamChange{ | ||
| paramsproposaltypes.NewParamChange(transfertypes.StoreKey, string(transfertypes.KeyReceiveEnabled), "false"), | ||
| } | ||
|
|
||
| proposal := paramsproposaltypes.NewParameterChangeProposal(ibctesting.Title, ibctesting.Description, changes) | ||
| s.ExecuteGovProposal(ctx, chainA, chainAWallet, proposal) | ||
| } | ||
| }) | ||
|
|
||
| t.Run("ensure transfer params are disabled", func(t *testing.T) { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this a
Clientsection like we have for ICA? I am also adding one for transfer in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In another docs related PR?