Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api)!: remove unnecessary channel getter functions #5705

Merged
merged 15 commits into from
Jan 25, 2024

Conversation

colin-axner
Copy link
Contributor

Description

removes the extra getter functions that came with the exported.ChannelI interface. Unsure if someone would disagree with this proposed change so I split into a separate pr. I prefer the reduction of these functions as it keeps the code minimal and easier to grep

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9faaff5) 81.26% compared to head (023a8aa) 81.33%.
Report is 6 commits behind head on colin/rm-exported-channelI.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           colin/rm-exported-channelI    #5705      +/-   ##
==============================================================
+ Coverage                       81.26%   81.33%   +0.07%     
==============================================================
  Files                             199      199              
  Lines                           15237    15216      -21     
==============================================================
- Hits                            12382    12376       -6     
+ Misses                           2389     2375      -14     
+ Partials                          466      465       -1     
Files Coverage Δ
modules/apps/transfer/keeper/relay.go 90.94% <100.00%> (ø)
...odules/core/02-client/migrations/v7/solomachine.go 18.84% <ø> (+0.53%) ⬆️
modules/core/03-connection/keeper/verify.go 79.56% <100.00%> (+0.77%) ⬆️
modules/core/04-channel/types/channel.go 93.84% <ø> (+12.51%) ⬆️
modules/core/04-channel/types/codec.go 100.00% <ø> (ø)

Base automatically changed from colin/rm-exported-channelI to main January 24, 2024 15:35
@colin-axner colin-axner marked this pull request as ready for review January 24, 2024 15:47
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jan 24, 2024
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending removal of two calls in e2e that are causing em to fail, thanks for this clean-up! 🔥

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful stuff!

Think we need to remove two calls to channel.GetConnectionHops() in e2e

@crodriguezvega crodriguezvega changed the title refactor!: remove unnecessary channel getter functions refactor(api)!: remove unnecessary channel getter functions Jan 25, 2024
@colin-axner colin-axner merged commit 310a4bd into main Jan 25, 2024
64 of 65 checks passed
@colin-axner colin-axner deleted the colin/rm-channelI branch January 25, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants