-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api)!: remove unnecessary channel getter functions #5705
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## colin/rm-exported-channelI #5705 +/- ##
==============================================================
+ Coverage 81.26% 81.33% +0.07%
==============================================================
Files 199 199
Lines 15237 15216 -21
==============================================================
- Hits 12382 12376 -6
+ Misses 2389 2375 -14
+ Partials 466 465 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending removal of two calls in e2e that are causing em to fail, thanks for this clean-up! 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful stuff!
Think we need to remove two calls to channel.GetConnectionHops()
in e2e
Description
removes the extra getter functions that came with the exported.ChannelI interface. Unsure if someone would disagree with this proposed change so I split into a separate pr. I prefer the reduction of these functions as it keeps the code minimal and easier to grep
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.