Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api)!: remove unnecessary channel getter functions #5705

Merged
merged 15 commits into from
Jan 25, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:cosmos/ibc-go into colin/rm-channelI
  • Loading branch information
colin-axner committed Jan 24, 2024
commit c28786fc3aed485ce5b5b93e834f3957a26e374e
10 changes: 0 additions & 10 deletions modules/core/04-channel/types/channel.go
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
"github.com/cosmos/ibc-go/v8/modules/core/exported"
)

var (

Check failure on line 12 in modules/core/04-channel/types/channel.go

GitHub Actions / lint

File is not `gofumpt`-ed (gofumpt)

Check failure on line 12 in modules/core/04-channel/types/channel.go

GitHub Actions / lint

File is not `gofumpt`-ed (gofumpt)
_ exported.CounterpartyChannelI = (*Counterparty)(nil)
)

@@ -29,16 +29,6 @@
}
}

// IsOpen returns true if the channel state is OPEN
func (ch Channel) IsOpen() bool {
return ch.State == OPEN
}

// IsClosed returns true if the channel state is CLOSED
func (ch Channel) IsClosed() bool {
return ch.State == CLOSED
}

// ValidateBasic performs a basic validation of the channel fields
func (ch Channel) ValidateBasic() error {
if ch.State == UNINITIALIZED {
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.