feat: add NewErrorAcknowledgementWithCodespace to allow codespaces in ack errors #5788
Conversation
This new constructor comes with an implicit requirement that people do not change a given err's codespace between patch/non-state machine breaking versions. The codespace is inserted into the returned error to assist in debugging since the error code on its own is insufficient to debug the source of the error.
DimitrisJim
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
|
would be nice to backport this to at least the v8 line? I see that's where wasmd currently is. |
Yes, we can. But this change is state-machine breaking, right? So we would need a new minor release branch. |
shouldn't be for ibc-go considering we don't use it anywhere atm, yea? This just introduces a function. Maybe we should use it in order to output Would assume anyone using it would be cognizant that changing from NewAck to NewAckWithCodespace would be state machine breaking, though. (Its docstring definitely implies that, maybe we can emphasize it elsewhere?) |
|
Backport to v8.2 since it has an api addition. Also if it is used, then it becomes state machine breaking |
|
as we also discussed in call, looked into semver and API additions do indeed require a minor bump (see summary for MINOR here. Don't think our docs require updating since they explicitly mention we follow semver with modifications to accommodate state machine breaking changes. |
This new constructor comes with an implicit requirement that people do not change a given err's codespace between patch/non-state machine breaking versions. The codespace is inserted into the returned error to assist in debugging since the error code on its own is insufficient to debug the source of the error. Co-authored-by: Cian Hatton <cian@interchain.io> (cherry picked from commit e42d0d2)
… ack errors (backport #5788) (#5842) * feat: Add NewErrorAcknowledgementWithCodespace. (#5788) This new constructor comes with an implicit requirement that people do not change a given err's codespace between patch/non-state machine breaking versions. The codespace is inserted into the returned error to assist in debugging since the error code on its own is insufficient to debug the source of the error. Co-authored-by: Cian Hatton <cian@interchain.io> (cherry picked from commit e42d0d2) * add changelog --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
This new constructor comes with an implicit requirement that people do not change a given err's codespace between patch/non-state machine breaking versions. The codespace is inserted into the returned error to assist in debugging since the error code on its own is insufficient to debug the source of the error. Co-authored-by: Cian Hatton <cian@interchain.io> (cherry picked from commit e42d0d2)
This new constructor comes with an implicit requirement that people do not change a given err's codespace between patch/non-state machine breaking versions. The codespace is inserted into the returned error to assist in debugging since the error code on its own is insufficient to debug the source of the error. Co-authored-by: Cian Hatton <cian@interchain.io> (cherry picked from commit e42d0d2) Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Description
closes: #5736
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.