feat: add NewErrorAcknowledgementWithCodespace to allow codespaces in ack errors (backport #5788) #5842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This new constructor comes with an implicit requirement that people do not change a given err's codespace between patch/non-state machine breaking versions. The codespace is inserted into the returned error to assist in debugging since the error code on its own is insufficient to debug the source of the error. Co-authored-by: Cian Hatton <cian@interchain.io> (cherry picked from commit e42d0d2)
mergify
bot
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
DimitrisJim
approved these changes
Feb 14, 2024
chatton
approved these changes
Feb 14, 2024
mergify
bot
requested review from
crodriguezvega and
charleenfei
as code owners
crodriguezvega
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #5788 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com