feat(depinject): support for core #5976
Conversation
…-for-v2-apps # Conflicts: # modules/core/module.go
…-dependency-injection-for-v2-apps # Conflicts: # proto/ibc/core/module/v1/module.proto
…-dependency-injection-for-v2-apps # Conflicts: # go.mod
…-dependency-injection-for-v2-apps
…upport-code # Conflicts: # go.mod # modules/core/module.go
…upport-code # Conflicts: # e2e/go.mod # go.mod # go.sum # modules/core/module.go
…upport-code # Conflicts: # e2e/go.mod # go.mod
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
|
…upport-core # Conflicts: # go.mod
| appmodule.Register( | ||
| &modulev1.Module{}, | ||
| appmodule.Provide(ProvideModule), | ||
| ) |
There was a problem hiding this comment.
I'm thinking that we may need something like InvokeAddRoutes here which will register []porttypes.IBCModule on the router..
Something similar to x/gov maybe: https://github.com/cosmos/cosmos-sdk/blob/main/x/gov/depinject.go#L100
Hopefully we can use this as some kind of example. Happy to work on this once the initial PRs are merged.
| @@ -2,7 +2,7 @@ version: v1 | |||
| plugins: | |||
| - name: gocosmos | |||
| out: .. | |||
| opt: plugins=grpc,Mgoogle/protobuf/any.proto=github.com/cosmos/cosmos-sdk/codec/types | |||
| opt: plugins=grpc,Mgoogle/protobuf/any.proto=github.com/cosmos/cosmos-sdk/codec/types,Mcosmos/app/v1alpha1/module.proto=cosmossdk.io/api/cosmos/app/v1alpha1 | |||
There was a problem hiding this comment.
ah, this is probably why we need Mcosmos/app/v1alpha1/module.proto=cosmossdk.io/api/cosmos/app/v1alpha1. Wonder if the override Damian added in #5968 should cover this.
# Conflicts: # api/capability/v1/capability.pulsar.go # api/capability/v1/genesis.pulsar.go # api/go.mod # api/go.sum # api/ibc/applications/fee/v1/fee.pulsar.go # api/ibc/applications/fee/v1/query.pulsar.go # api/ibc/applications/fee/v1/tx.pulsar.go # api/ibc/applications/interchain_accounts/controller/v1/tx.pulsar.go # api/ibc/applications/interchain_accounts/host/v1/host.pulsar.go # api/ibc/applications/interchain_accounts/host/v1/tx.pulsar.go # api/ibc/applications/interchain_accounts/v1/account.pulsar.go # api/ibc/applications/interchain_accounts/v1/packet.pulsar.go # api/ibc/applications/transfer/v1/authz.pulsar.go # api/ibc/applications/transfer/v1/genesis.pulsar.go # api/ibc/applications/transfer/v1/query.pulsar.go # api/ibc/applications/transfer/v1/tx.pulsar.go # api/ibc/core/channel/v1/query.pulsar.go # api/ibc/core/channel/v1/tx.pulsar.go # api/ibc/core/client/v1/client.pulsar.go # api/ibc/core/client/v1/query.pulsar.go # api/ibc/core/client/v1/tx.pulsar.go # api/ibc/core/commitment/v1/commitment.pulsar.go # api/ibc/core/connection/v1/query.pulsar.go # api/ibc/core/connection/v1/tx.pulsar.go # api/ibc/lightclients/solomachine/v2/solomachine.pulsar.go # api/ibc/lightclients/solomachine/v3/solomachine.pulsar.go # api/ibc/lightclients/tendermint/v1/tendermint.pulsar.go # api/ibc/lightclients/wasm/v1/query.pulsar.go # api/ibc/lightclients/wasm/v1/tx.pulsar.go # proto/buf.gen.pulsar.yaml
|
I have downgraded the |
Nah, it doesn't work. |
|
nice @crodriguezvega! Forgot ics23's |
hehe, nice, it's cool that it builds. 😅 |
|
@DimitrisJim If the CI is green and you approve this one, I can rebase the other PRs and hopefully we can get them merged quickly. |
|
Description
Adding support for
ibcpackage.ref: #3560
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.