Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtoJSON regression in Serde derives #165

Closed
Tracked by #343
hdevalence opened this issue Nov 30, 2023 · 0 comments · Fixed by #166
Closed
Tracked by #343

ProtoJSON regression in Serde derives #165

hdevalence opened this issue Nov 30, 2023 · 0 comments · Fixed by #166

Comments

@hdevalence
Copy link

We noticed a regression since #95 (not sure where or when exactly) that results in the ibc-proto types having broken Serialize, Deserialize implementations.

Test case:

In that test code, the Ics20Withdrawal is a Penumbra-specific action that includes an IBC TimeoutHeight. Our Proto build configuration place the ibc-proto types as the generated code for ibc proto messages, so its Serialize and Deserialize impls forward to the ones in this crate.

Looking at the code in https://github.com/cosmos/ibc-proto-rs/blob/main/tools/proto-compiler/src/cmd/compile.rs , I don't see any invocations of pbjson_build at all, I'm not sure what happened since #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant