Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ics20Withdraw part 2 #248

Closed
Tracked by #343
grod220 opened this issue Nov 17, 2023 · 4 comments · Fixed by #795
Closed
Tracked by #343

Ics20Withdraw part 2 #248

grod220 opened this issue Nov 17, 2023 · 4 comments · Fixed by #795
Assignees
Labels
rpc Related to proto rpc services/methods

Comments

@grod220
Copy link
Collaborator

grod220 commented Nov 17, 2023

Complete remainder of IBC out work (first issue: #132).

Currently blocked by revisionHeight serialization bug.

Things left to do:

  • Re-enable IBC tab
  • Add form validation
  • Test if it works

To start: restrict token paths. UI restricts outbound transfers on channel A to native tokens & tokens sent from channel A. This means we don't need to worry about unwinding initially.

More:

  • Channel source needs to be “channel source”
  • Asset denom cannot be display unit. Needs to be base unit.
  • Give it its own tab
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Nov 17, 2023
@grod220 grod220 moved this from 🗄️ Backlog to 🛑 Blocked in Penumbra web Nov 30, 2023
@grod220 grod220 self-assigned this Nov 30, 2023
@grod220
Copy link
Collaborator Author

grod220 commented Nov 30, 2023

Blocked by: cosmos/ibc-proto-rs#165

@grod220
Copy link
Collaborator Author

grod220 commented Jan 2, 2024

Now unblocked by: penumbra-zone/penumbra#3550

@grod220 grod220 mentioned this issue Jan 4, 2024
18 tasks
@grod220 grod220 moved this from 🛑 Blocked to 📝 Todo in Penumbra web Jan 4, 2024
@grod220 grod220 removed their assignment Jan 4, 2024
@grod220 grod220 added the rpc Related to proto rpc services/methods label Jan 5, 2024
@grod220 grod220 moved this from 📝 Todo to 🏗 In progress in Penumbra web Jan 22, 2024
@grod220 grod220 self-assigned this Jan 22, 2024
@grod220
Copy link
Collaborator Author

grod220 commented Jan 23, 2024

Not in a place where we can productively work on at the moment.

  • IBC relayers are down. Cannot confirm successful tx.
  • Dev branch of extension is far ahead of former testnet release (on preview). Cannot index assets correctly and display them on the form.
  • Testnet-preview does not have clients running

Should wait until next testnet and extension release to pick this up.

Branch: ibc-part-2

@grod220 grod220 moved this from 🏗 In progress to 🛑 Blocked in Penumbra web Jan 23, 2024
@grod220 grod220 moved this from 🛑 Blocked to 📝 Todo in Penumbra web Feb 8, 2024
@grod220 grod220 moved this from 📝 Todo to 🏗 In progress in Penumbra web Feb 13, 2024
@grod220 grod220 moved this from 🏗 In progress to 🛑 Blocked in Penumbra web Feb 13, 2024
@grod220 grod220 removed their assignment Feb 13, 2024
@grod220
Copy link
Collaborator Author

grod220 commented Feb 13, 2024

@grod220 grod220 moved this from 🛑 Blocked to 🗄️ Backlog in Penumbra web Feb 23, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Feb 29, 2024
@grod220 grod220 moved this from 📝 Todo to 🏗 In progress in Penumbra web Mar 13, 2024
@grod220 grod220 self-assigned this Mar 13, 2024
@grod220 grod220 mentioned this issue Mar 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc Related to proto rpc services/methods
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant