New Tab: IBC #795
New Tab: IBC #795
Conversation
| const validateAddress = (chain: Chain | undefined, address: string): boolean => { | ||
| if (!chain || address === '') return false; | ||
| return bech32IsValid(address, chain.addressPrefix); | ||
| }; |
There was a problem hiding this comment.
Can we allow any address if the chain is undefined?
There was a problem hiding this comment.
This particular check where chain can be undefined relates to zustand booting up empty and then populating with chain data from our hard-coded registry. We can't transfer without a channel-id being available first.
| import { joinLoHiAmount } from '@penumbra-zone/types/src/amount'; | ||
| import { bech32Address } from '@penumbra-zone/bech32'; | ||
|
|
||
| export const Ics20WithdrawalComponent = ({ value }: { value: Ics20Withdrawal }) => { |
There was a problem hiding this comment.
Ics20Withdraw's do not have a special private/public case fyi
There was a problem hiding this comment.
Not immediately but we probably do want to have a view for the Ics20Withdrawal so that we can insert:
- token metadata
- address view (of return address)
grod220
requested review from
jessepinho,
Valentine1898,
TalDerei and
turbocrime
|
I get this error when trying to enter amount greater than 2, while I have a note with amount 2.
|
|
@Valentine1898 let's pair on that error you're seeing |
grod220
force-pushed
the
ibc-page
branch
2 times, most recently
from
40644a0 to
b027fdf
Compare
| <div className='grow overflow-auto p-[30px] pb-44 pt-10'> | ||
| <p className='bg-text-linear bg-clip-text pb-2 font-headline text-2xl font-bold text-transparent'> |
There was a problem hiding this comment.
Fixes bug where tx approval window does not scroll all the way down given approve/deny buttons overlap it with a fixed position
| <div> | ||
| {/* eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing */} | ||
| {memoView.value.plaintext?.text || ( | ||
| <span className='italic text-gray-600'>== none ==</span> | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
Was confused by seeing in the text box. So added a bit of styling instead:
Closes #248
Does not address design, just functional elements. Design to come next. Updates: