ChainId should serialize itself without using tendermint::chain::Id
#729
Labels
O: decoupling
Objective: aims to separate concerns and cause to independent, reusable components
Milestone
Comments
plafer
added
the
O: decoupling
7 tasks
Farhad-Shabani
pushed a commit
that referenced
this issue
Jun 27, 2023
* Refactor chain_id to avoid cloning to chain_id.to_string(). Convert chain_id from a raw string slice to a chain identifier type in several code locations. * feat(ibc): remove `tendermint::chain::Id` dependency and use `FromStr` to construct `ClientType` in `ics07_tendermint` and `ics02_client` module (#729 and #731).
Farhad-Shabani
pushed a commit
that referenced
this issue
Sep 9, 2024
* Refactor chain_id to avoid cloning to chain_id.to_string(). Convert chain_id from a raw string slice to a chain identifier type in several code locations. * feat(ibc): remove `tendermint::chain::Id` dependency and use `FromStr` to construct `ClientType` in `ics07_tendermint` and `ics02_client` module (#729 and #731).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the
serde::Serializationis achieved by first converting totendermint::chain::Id, and then serializing from there. We should instead implementSerializeandDeserializemanually by first converting to aString, then serializing thatString, and vice-versa, as we do with thetendermint::chain::Idtype.This is part of the effort to completely remove the dependency on Tendermint from core IBC.
The text was updated successfully, but these errors were encountered: