feat: use FromStr in client_type functions to construct ClientType
#731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 72.32% 72.35% +0.03%
==========================================
Files 116 116
Lines 15524 15526 +2
==========================================
+ Hits 11227 11234 +7
+ Misses 4297 4292 -5
☔ View full report in Codecov by Sentry. |
Comment on lines
41
to
47
| impl TryFrom<String> for ClientType { | ||
| type Error = IdentifierError; | ||
|
|
||
| fn try_from(s: String) -> Result<Self, Self::Error> { | ||
| Self::new(s) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we use FromStr instead of TryFrom here? to maintain consistency with the existing conversion methods for ClientId, ConnectionId, and ChannelId. Also, won't have to deal with to_string() everywhere.
…ics02_client`, `ics02_client/events`, `ics03_connection/events` and `mock/client_state`
DaviRain-Su
changed the title
TryFrom in client_type functions to construct ClientTypeFromStr in client_type functions to construct ClientType
Farhad-Shabani
pushed a commit
that referenced
this pull request
Jun 27, 2023
* Refactor chain_id to avoid cloning to chain_id.to_string(). Convert chain_id from a raw string slice to a chain identifier type in several code locations. * feat(ibc): remove `tendermint::chain::Id` dependency and use `FromStr` to construct `ClientType` in `ics07_tendermint` and `ics02_client` module (#729 and #731).
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…pe` (#731) * feat: use `TryFrom` in `client_type` functions to construct `ClientType` * Fix ClientType conversion method in identifier.rs * Refactor client type parsing using `FromStr` in `ics07_tendermint`, `ics02_client`, `ics02_client/events`, `ics03_connection/events` and `mock/client_state` * refactor: use core::str instead of std::str in mod.rs file of ICS07 Tendermint client
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Refactor chain_id to avoid cloning to chain_id.to_string(). Convert chain_id from a raw string slice to a chain identifier type in several code locations. * feat(ibc): remove `tendermint::chain::Id` dependency and use `FromStr` to construct `ClientType` in `ics07_tendermint` and `ics02_client` module (#729 and #731).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.