feat: implement 08-wasm client types
#1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deps: bump ibc-proto rev
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 71.21% 71.45% +0.24%
==========================================
Files 178 187 +9
Lines 18198 18516 +318
==========================================
+ Hits 12959 13230 +271
- Misses 5239 5286 +47 ☔ View full report in Codecov by Sentry. |
Merged
4 tasks
rnbguy
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Thanks @Farhad-Shabani for taking care of this. 🙏
I requested some changes. The most important ones are the unit tests.
.changelog/unreleased/features/1030-implement-08-wasm-client-types.md
Outdated
Show resolved
Hide resolved
Farhad-Shabani
commented
Jan 11, 2024
rnbguy
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Great work @Farhad-Shabani ! 👌 I am approving the PR with a question about bytes dependency.
I also added some new tests. If you approve of them, go ahead with merging.
|
Thank you @rnbguy for the tests. 👌🏻 |
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: implement 08-wasm client types deps: bump ibc-proto rev * fix: no_std compatibility * imp: add all of the Wasm msg types * chore: update Cargo.lock * chore: use ibc-proto-rs rev which contains sovereign protos * nit: correct ibc-proto-rs rev * chore: apply review comments * fix: use From instead of TryFrom where Error = Infallible * add WASM_CLIENT_TYPE * add tests for Base64 * add tests for ClientType * add tests in wasm client type crate * use bytes over strings * nit: remove bytes --------- Co-authored-by: Ranadeep Biswas <mail@rnbguy.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1030
Related PR for adding required proto types: cosmos/ibc-proto-rs#170
Notes
Vec<u8>, aBytetype alias has been defined, allowing for better encapsulation and inclusion of potential implementation of various checks in the future, such as length limitations or etc.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.