Copy relevant ADRs from hermes repository #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu55a1n1
suggested changes
Oct 6, 2022
hu55a1n1
reviewed
Oct 6, 2022
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
|
Thank you both, appreciate the super speedy turnover! Now I can refer users/devs to module-related ADRs on this repo (instead of the hermes repo, which can be confusing). |
plafer
added a commit
that referenced
this pull request
Oct 6, 2022
* Add ADRs * Update docs/architecture/adr-002-error.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-003-ics20-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-001-handler-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
plafer
added a commit
that referenced
this pull request
Oct 11, 2022
* client_id IbcEvent refactor * Remove NewBlock and ChainError events * Refactor update_client event * clippy * Improve CreateClient event type * Improve UpdateClient event type * refactor ClientMisbehaviour event * UpgradeClient event refactor * Remove Client Attributes * Add EventMessage * client handlers emit ibcevent message * Copy relevant ADRs from hermes repository (#147) * Add ADRs * Update docs/architecture/adr-002-error.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-003-ics20-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-001-handler-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> * Fix CI (#151) * std crate enabled for tests * clippy no-default-features: still use clock feature * patch ibc-proto to not use latest * fix ibc-proto patch properly * Allow deprecated (for crossing hellos fields) * Remove ibc-proto rev for no-std * fix no-std ibc-proto patch * Remove comment * fmt * Fix tests Events will be tested in their own test rather than spread across all tests. * ADR 012: Handlers validation and execution separation (#153) * init adr 12 * Host based API * Add appendices * Add section on event logging * Add .changelog entry * Fix TypedStore associated type (syntax only) * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Philippe Laferrière <plafer@protonmail.com> * validation vs execution clarifications * Move ValidationContext and ExecutionContext methods to appendix * Context clarification * Rework Host-based API section * ValidationContext and ExecutionContext clarification * Move Event logging section + misc * typo * Remove statement. Was mentioned earlier already. * IbcStore blanket implementation * IbcValueForPath rework * Remove IbcSerde from main ADR * TypedStore -> SubStore * diagram * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * add context for why the validation/execution split is necessary * add trait bounds * Rename ADR012 -> ADR005 * Apply suggestions from code review Change ADR status from Proposed to Accepted Co-authored-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Philippe Laferriere <plafer@protonmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Setup unclog based changelog (#152) * Add filtered changelog with ibc relevant entries * Init unclog * Add unreleased changelog entries * clippy * Remove "message" ibc event * update_client event test * Remove unused function * upgrade client event * changelog * Revert "Remove unused function" This reverts commit 66459cc. * Remove EMPTY event * Use derive_more::From * Remove Display from IbcEvent * changelog Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Add ADRs * Update docs/architecture/adr-002-error.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-003-ics20-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-001-handler-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* client_id IbcEvent refactor * Remove NewBlock and ChainError events * Refactor update_client event * clippy * Improve CreateClient event type * Improve UpdateClient event type * refactor ClientMisbehaviour event * UpgradeClient event refactor * Remove Client Attributes * Add EventMessage * client handlers emit ibcevent message * Copy relevant ADRs from hermes repository (#147) * Add ADRs * Update docs/architecture/adr-002-error.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-003-ics20-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-001-handler-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> * Fix CI (#151) * std crate enabled for tests * clippy no-default-features: still use clock feature * patch ibc-proto to not use latest * fix ibc-proto patch properly * Allow deprecated (for crossing hellos fields) * Remove ibc-proto rev for no-std * fix no-std ibc-proto patch * Remove comment * fmt * Fix tests Events will be tested in their own test rather than spread across all tests. * ADR 012: Handlers validation and execution separation (#153) * init adr 12 * Host based API * Add appendices * Add section on event logging * Add .changelog entry * Fix TypedStore associated type (syntax only) * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Philippe Laferrière <plafer@protonmail.com> * validation vs execution clarifications * Move ValidationContext and ExecutionContext methods to appendix * Context clarification * Rework Host-based API section * ValidationContext and ExecutionContext clarification * Move Event logging section + misc * typo * Remove statement. Was mentioned earlier already. * IbcStore blanket implementation * IbcValueForPath rework * Remove IbcSerde from main ADR * TypedStore -> SubStore * diagram * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * add context for why the validation/execution split is necessary * add trait bounds * Rename ADR012 -> ADR005 * Apply suggestions from code review Change ADR status from Proposed to Accepted Co-authored-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Philippe Laferriere <plafer@protonmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Setup unclog based changelog (#152) * Add filtered changelog with ibc relevant entries * Init unclog * Add unreleased changelog entries * clippy * Remove "message" ibc event * update_client event test * Remove unused function * upgrade client event * changelog * Revert "Remove unused function" This reverts commit 66459cc. * Remove EMPTY event * Use derive_more::From * Remove Display from IbcEvent * changelog Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #140
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.