Fix CI #151

plafer · 2022-10-06T14:24:43Z

Closes: #149

PR author checklist:

Added changelog entry, using unclog.
Added tests.
Linked to GitHub issue.
Updated code comments and documentation (e.g., docs/).
Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

Reviewed Files changed in the GitHub PR explorer.
Manually tested (in case integration/unit/mock tests are absent).

hu55a1n1 · 2022-10-06T15:50:08Z

crates/ibc/src/lib.rs

@@ -46,7 +49,7 @@

 extern crate alloc;

-#[cfg(feature = "std")]
+#[cfg(any(test, feature = "std"))]


Is this still required now that we've changed the CI command?

Yes, otherwise we get the "can't find std" errors

hu55a1n1 · 2022-10-06T15:50:20Z

.github/workflows/rust.yml

@@ -72,7 +72,7 @@ jobs:
      - uses: actions-rs/clippy-check@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
-          args: --no-default-features
+          args: --no-default-features --features "clock" --all-targets # tests need the clock feature


* std crate enabled for tests * clippy no-default-features: still use clock feature * patch ibc-proto to not use latest * fix ibc-proto patch properly * Allow deprecated (for crossing hellos fields) * Remove ibc-proto rev for no-std * fix no-std ibc-proto patch * Remove comment

* client_id IbcEvent refactor * Remove NewBlock and ChainError events * Refactor update_client event * clippy * Improve CreateClient event type * Improve UpdateClient event type * refactor ClientMisbehaviour event * UpgradeClient event refactor * Remove Client Attributes * Add EventMessage * client handlers emit ibcevent message * Copy relevant ADRs from hermes repository (#147) * Add ADRs * Update docs/architecture/adr-002-error.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-003-ics20-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-001-handler-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> * Fix CI (#151) * std crate enabled for tests * clippy no-default-features: still use clock feature * patch ibc-proto to not use latest * fix ibc-proto patch properly * Allow deprecated (for crossing hellos fields) * Remove ibc-proto rev for no-std * fix no-std ibc-proto patch * Remove comment * fmt * Fix tests Events will be tested in their own test rather than spread across all tests. * ADR 012: Handlers validation and execution separation (#153) * init adr 12 * Host based API * Add appendices * Add section on event logging * Add .changelog entry * Fix TypedStore associated type (syntax only) * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Philippe Laferrière <plafer@protonmail.com> * validation vs execution clarifications * Move ValidationContext and ExecutionContext methods to appendix * Context clarification * Rework Host-based API section * ValidationContext and ExecutionContext clarification * Move Event logging section + misc * typo * Remove statement. Was mentioned earlier already. * IbcStore blanket implementation * IbcValueForPath rework * Remove IbcSerde from main ADR * TypedStore -> SubStore * diagram * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * add context for why the validation/execution split is necessary * add trait bounds * Rename ADR012 -> ADR005 * Apply suggestions from code review Change ADR status from Proposed to Accepted Co-authored-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Philippe Laferriere <plafer@protonmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Setup unclog based changelog (#152) * Add filtered changelog with ibc relevant entries * Init unclog * Add unreleased changelog entries * clippy * Remove "message" ibc event * update_client event test * Remove unused function * upgrade client event * changelog * Revert "Remove unused function" This reverts commit 66459cc. * Remove EMPTY event * Use derive_more::From * Remove Display from IbcEvent * changelog Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com>

This change starts fuzzing for: * ExistenceProof.Calculate * VerifyNonMembership * CombineProofs

* std crate enabled for tests * clippy no-default-features: still use clock feature * patch ibc-proto to not use latest * fix ibc-proto patch properly * Allow deprecated (for crossing hellos fields) * Remove ibc-proto rev for no-std * fix no-std ibc-proto patch * Remove comment

* client_id IbcEvent refactor * Remove NewBlock and ChainError events * Refactor update_client event * clippy * Improve CreateClient event type * Improve UpdateClient event type * refactor ClientMisbehaviour event * UpgradeClient event refactor * Remove Client Attributes * Add EventMessage * client handlers emit ibcevent message * Copy relevant ADRs from hermes repository (#147) * Add ADRs * Update docs/architecture/adr-002-error.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-003-ics20-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-001-handler-implementation.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update docs/architecture/adr-004-light-client-crates-extraction.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> * Fix CI (#151) * std crate enabled for tests * clippy no-default-features: still use clock feature * patch ibc-proto to not use latest * fix ibc-proto patch properly * Allow deprecated (for crossing hellos fields) * Remove ibc-proto rev for no-std * fix no-std ibc-proto patch * Remove comment * fmt * Fix tests Events will be tested in their own test rather than spread across all tests. * ADR 012: Handlers validation and execution separation (#153) * init adr 12 * Host based API * Add appendices * Add section on event logging * Add .changelog entry * Fix TypedStore associated type (syntax only) * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Philippe Laferrière <plafer@protonmail.com> * validation vs execution clarifications * Move ValidationContext and ExecutionContext methods to appendix * Context clarification * Rework Host-based API section * ValidationContext and ExecutionContext clarification * Move Event logging section + misc * typo * Remove statement. Was mentioned earlier already. * IbcStore blanket implementation * IbcValueForPath rework * Remove IbcSerde from main ADR * TypedStore -> SubStore * diagram * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update docs/architecture/adr-012-handlers-redesign.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * add context for why the validation/execution split is necessary * add trait bounds * Rename ADR012 -> ADR005 * Apply suggestions from code review Change ADR status from Proposed to Accepted Co-authored-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Philippe Laferriere <plafer@protonmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Setup unclog based changelog (#152) * Add filtered changelog with ibc relevant entries * Init unclog * Add unreleased changelog entries * clippy * Remove "message" ibc event * update_client event test * Remove unused function * upgrade client event * changelog * Revert "Remove unused function" This reverts commit 66459cc. * Remove EMPTY event * Use derive_more::From * Remove Display from IbcEvent * changelog Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com>

plafer added 2 commits October 6, 2022 10:23

std crate enabled for tests

ba5e649

clippy no-default-features: still use clock feature

49f3f52

plafer requested a review from hu55a1n1 October 6, 2022 14:24

plafer added 6 commits October 6, 2022 10:39

patch ibc-proto to not use latest

95e596f

fix ibc-proto patch properly

bd34cf9

Allow deprecated (for crossing hellos fields)

62500c1

Remove ibc-proto rev for no-std

8f432ad

fix no-std ibc-proto patch

4f485d9

Remove comment

bad7b12

hu55a1n1 reviewed Oct 6, 2022

View reviewed changes

hu55a1n1 approved these changes Oct 6, 2022

View reviewed changes

plafer merged commit bb3a968 into main Oct 6, 2022

plafer deleted the plafer/149-nostd-ci-fix branch October 6, 2022 16:45

shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this pull request Nov 4, 2023

test: go: start fuzzers (cosmos#151)

a507177

This change starts fuzzing for: * ExistenceProof.Calculate * VerifyNonMembership * CombineProofs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CI #151

Fix CI #151

plafer commented Oct 6, 2022

hu55a1n1 Oct 6, 2022

plafer Oct 6, 2022

hu55a1n1 Oct 6, 2022

Fix CI #151

Fix CI #151

Conversation

plafer commented Oct 6, 2022

PR author checklist:

Reviewer checklist:

hu55a1n1 Oct 6, 2022

Choose a reason for hiding this comment

plafer Oct 6, 2022

Choose a reason for hiding this comment

hu55a1n1 Oct 6, 2022

Choose a reason for hiding this comment