Misbehaviour handling implementation #215

hu55a1n1 · 2022-11-03T17:47:23Z

Closes: #12

Description

Targets ibc-go v5.0.1

PR author checklist:

Added changelog entry, using unclog.
Added tests.
Linked to GitHub issue.
Updated code comments and documentation (e.g., docs/).
Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

Reviewed Files changed in the GitHub PR explorer.
Manually tested (in case integration/unit/mock tests are absent).

hu55a1n1 · 2022-11-07T08:41:40Z

Blocked on informalsystems/tendermint-rs#1222

…our-handling

-> ConsensusStateTimestampGteTrustingPeriod

…ainst_trusted()

…our-handling

crates/ibc/src/core/ics02_client/handler/misbehaviour.rs

ancazamfir

Looks great, thanks @hu55a1n1!

* Add ClientState::check_misbehaviour_and_update_state() * Implement misbehaviour handler * impl Protobuf<Any> for Misbehaviour * Remove redundant definition of decode_header() * Implement ChainId::with_version() * Getters for Tm Misbehaviour * Add missing checks for conversion from RawMisbehaviour * Make TmClientState::with_frozen_height() infallible * Implement TmClientState::check_misbehaviour_and_update_state() * Cleanup inner functions * Cleanup errors * Clippy fix * Ctor for TmMisbehaviour * Use git dependencies for tendermint crates * Add VerifyCommitLightTrusting check * Add VerifyCommit check * Clippy fix * Patch tendermint deps for no-std-check * Convert Tendermint VerificationError * Add helpers `Header::as_{un}trusted_block_state()` * Reorder untrusted verification logic * Reorder trusted verification logic * Misbehavior -> misbehaviour * Check for matching chain-ids * cargo update ci/no-std-check * Fix build failure after merge with main * Update for API changes in tm PR * Delete ci/no-std-check/Cargo.lock * Add changelog entry * Cleanup (naming & comments) * Rename check_trusted_header() -> check_header_validator_set() * Rename check_misbehaviour_header() -> check_header_and_validator_set() * Rename MisbehaviourConsensusStateTimestampGteTrustingPeriod -> ConsensusStateTimestampGteTrustingPeriod * Rename verify_misbehaviour_header_commit() -> verify_header_commit_against_trusted() * Remove redundant client state expired check * Impl Protobuf conversions for mock Misbehaviour * Impl check_misbehaviour_and_update_state() for mock Misbehaviour * Remove cargo patches * Fixes after tendermint-rs bump * Fix typo * Add tests * MockClientState::with_frozen_height() * Provide MockContext helper to set client chain-id * Conversions from HostBlock -> TmLightBlock -> TmHeader * Fix tests * Clippy fix * Cleanup tests * Add comments for tests * Clippy fix * Rustfmt

…S-3) (#257) * `ConnOpenInit::validate` * conn_open_init: execute * conn_open_try `validate` and `execute` * conn_open_ack::validate * conn_open_ack::execute * conn_open_confirm::validate * conn_open_confirm::execute * changelog * LocalVars * validate_impl and execute_impl * Remove useless clone * fix ConnOpenInit::validate * fix conn_open_ack (as in #272) * conn_open_try: LocalVars * conn_open_try validate/execute impl * conn_open_ack LocalVars * conn_open_ack impl * Track code coverage with `cargo-llvm-cov` and codecov.io (#277) * Track code coverage with `cargo-llvm-cov` * Add changelog entry * Add coverage badge to the README * Misbehaviour handling implementation (#215) * Add ClientState::check_misbehaviour_and_update_state() * Implement misbehaviour handler * impl Protobuf<Any> for Misbehaviour * Remove redundant definition of decode_header() * Implement ChainId::with_version() * Getters for Tm Misbehaviour * Add missing checks for conversion from RawMisbehaviour * Make TmClientState::with_frozen_height() infallible * Implement TmClientState::check_misbehaviour_and_update_state() * Cleanup inner functions * Cleanup errors * Clippy fix * Ctor for TmMisbehaviour * Use git dependencies for tendermint crates * Add VerifyCommitLightTrusting check * Add VerifyCommit check * Clippy fix * Patch tendermint deps for no-std-check * Convert Tendermint VerificationError * Add helpers `Header::as_{un}trusted_block_state()` * Reorder untrusted verification logic * Reorder trusted verification logic * Misbehavior -> misbehaviour * Check for matching chain-ids * cargo update ci/no-std-check * Fix build failure after merge with main * Update for API changes in tm PR * Delete ci/no-std-check/Cargo.lock * Add changelog entry * Cleanup (naming & comments) * Rename check_trusted_header() -> check_header_validator_set() * Rename check_misbehaviour_header() -> check_header_and_validator_set() * Rename MisbehaviourConsensusStateTimestampGteTrustingPeriod -> ConsensusStateTimestampGteTrustingPeriod * Rename verify_misbehaviour_header_commit() -> verify_header_commit_against_trusted() * Remove redundant client state expired check * Impl Protobuf conversions for mock Misbehaviour * Impl check_misbehaviour_and_update_state() for mock Misbehaviour * Remove cargo patches * Fixes after tendermint-rs bump * Fix typo * Add tests * MockClientState::with_frozen_height() * Provide MockContext helper to set client chain-id * Conversions from HostBlock -> TmLightBlock -> TmHeader * Fix tests * Clippy fix * Cleanup tests * Add comments for tests * Clippy fix * Rustfmt * Fix wrong main branch name in code coverage job (#280) * implement `ValidationContext` for `MockContext` * conn_open_init: test validate() * Add `execute` entrypoint * re-export validate and execute * test validate() in connection handlers * Use into() instead of ContextError directly * reexport ContextError * fmt Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.26.1 to 1.27.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.26.1...v1.27.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Add ClientState::check_misbehaviour_and_update_state() * Implement misbehaviour handler * impl Protobuf<Any> for Misbehaviour * Remove redundant definition of decode_header() * Implement ChainId::with_version() * Getters for Tm Misbehaviour * Add missing checks for conversion from RawMisbehaviour * Make TmClientState::with_frozen_height() infallible * Implement TmClientState::check_misbehaviour_and_update_state() * Cleanup inner functions * Cleanup errors * Clippy fix * Ctor for TmMisbehaviour * Use git dependencies for tendermint crates * Add VerifyCommitLightTrusting check * Add VerifyCommit check * Clippy fix * Patch tendermint deps for no-std-check * Convert Tendermint VerificationError * Add helpers `Header::as_{un}trusted_block_state()` * Reorder untrusted verification logic * Reorder trusted verification logic * Misbehavior -> misbehaviour * Check for matching chain-ids * cargo update ci/no-std-check * Fix build failure after merge with main * Update for API changes in tm PR * Delete ci/no-std-check/Cargo.lock * Add changelog entry * Cleanup (naming & comments) * Rename check_trusted_header() -> check_header_validator_set() * Rename check_misbehaviour_header() -> check_header_and_validator_set() * Rename MisbehaviourConsensusStateTimestampGteTrustingPeriod -> ConsensusStateTimestampGteTrustingPeriod * Rename verify_misbehaviour_header_commit() -> verify_header_commit_against_trusted() * Remove redundant client state expired check * Impl Protobuf conversions for mock Misbehaviour * Impl check_misbehaviour_and_update_state() for mock Misbehaviour * Remove cargo patches * Fixes after tendermint-rs bump * Fix typo * Add tests * MockClientState::with_frozen_height() * Provide MockContext helper to set client chain-id * Conversions from HostBlock -> TmLightBlock -> TmHeader * Fix tests * Clippy fix * Cleanup tests * Add comments for tests * Clippy fix * Rustfmt

…S-3) (#257) * `ConnOpenInit::validate` * conn_open_init: execute * conn_open_try `validate` and `execute` * conn_open_ack::validate * conn_open_ack::execute * conn_open_confirm::validate * conn_open_confirm::execute * changelog * LocalVars * validate_impl and execute_impl * Remove useless clone * fix ConnOpenInit::validate * fix conn_open_ack (as in #272) * conn_open_try: LocalVars * conn_open_try validate/execute impl * conn_open_ack LocalVars * conn_open_ack impl * Track code coverage with `cargo-llvm-cov` and codecov.io (#277) * Track code coverage with `cargo-llvm-cov` * Add changelog entry * Add coverage badge to the README * Misbehaviour handling implementation (#215) * Add ClientState::check_misbehaviour_and_update_state() * Implement misbehaviour handler * impl Protobuf<Any> for Misbehaviour * Remove redundant definition of decode_header() * Implement ChainId::with_version() * Getters for Tm Misbehaviour * Add missing checks for conversion from RawMisbehaviour * Make TmClientState::with_frozen_height() infallible * Implement TmClientState::check_misbehaviour_and_update_state() * Cleanup inner functions * Cleanup errors * Clippy fix * Ctor for TmMisbehaviour * Use git dependencies for tendermint crates * Add VerifyCommitLightTrusting check * Add VerifyCommit check * Clippy fix * Patch tendermint deps for no-std-check * Convert Tendermint VerificationError * Add helpers `Header::as_{un}trusted_block_state()` * Reorder untrusted verification logic * Reorder trusted verification logic * Misbehavior -> misbehaviour * Check for matching chain-ids * cargo update ci/no-std-check * Fix build failure after merge with main * Update for API changes in tm PR * Delete ci/no-std-check/Cargo.lock * Add changelog entry * Cleanup (naming & comments) * Rename check_trusted_header() -> check_header_validator_set() * Rename check_misbehaviour_header() -> check_header_and_validator_set() * Rename MisbehaviourConsensusStateTimestampGteTrustingPeriod -> ConsensusStateTimestampGteTrustingPeriod * Rename verify_misbehaviour_header_commit() -> verify_header_commit_against_trusted() * Remove redundant client state expired check * Impl Protobuf conversions for mock Misbehaviour * Impl check_misbehaviour_and_update_state() for mock Misbehaviour * Remove cargo patches * Fixes after tendermint-rs bump * Fix typo * Add tests * MockClientState::with_frozen_height() * Provide MockContext helper to set client chain-id * Conversions from HostBlock -> TmLightBlock -> TmHeader * Fix tests * Clippy fix * Cleanup tests * Add comments for tests * Clippy fix * Rustfmt * Fix wrong main branch name in code coverage job (#280) * implement `ValidationContext` for `MockContext` * conn_open_init: test validate() * Add `execute` entrypoint * re-export validate and execute * test validate() in connection handlers * Use into() instead of ContextError directly * reexport ContextError * fmt Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>

hu55a1n1 added 16 commits November 16, 2022 15:01

Add ClientState::check_misbehaviour_and_update_state()

3f879b3

Implement misbehaviour handler

95c10ee

impl Protobuf<Any> for Misbehaviour

f7de39a

Remove redundant definition of decode_header()

cbcebb8

Implement ChainId::with_version()

2d74fa8

Getters for Tm Misbehaviour

86530ad

Add missing checks for conversion from RawMisbehaviour

6a8c8f2

Make TmClientState::with_frozen_height() infallible

13097b8

Implement TmClientState::check_misbehaviour_and_update_state()

d65e7d5

Cleanup inner functions

c81a8ad

Cleanup errors

3fd4e41

Clippy fix

0917ea3

Ctor for TmMisbehaviour

66be4a4

Use git dependencies for tendermint crates

69c3e65

Add VerifyCommitLightTrusting check

a3a56b7

Add VerifyCommit check

0af89b0

hu55a1n1 force-pushed the hu55a1n1/12-misbehaviour-handling branch from 1d1bcb9 to 0af89b0 Compare November 16, 2022 13:34

hu55a1n1 added 3 commits November 17, 2022 13:46

Merge branch 'main' into hu55a1n1/12-misbehaviour-handling

6753d92

Clippy fix

038fd95

Patch tendermint deps for no-std-check

6415cd1

ancazamfir mentioned this pull request Nov 19, 2022

Implement verify_light() and verify_light_trusting() informalsystems/tendermint-rs#1226

Merged

5 tasks

hu55a1n1 added 8 commits November 22, 2022 14:35

Convert Tendermint VerificationError

84d4836

Add helpers Header::as_{un}trusted_block_state()

8315c8a

Reorder untrusted verification logic

176084a

Reorder trusted verification logic

aaa5e11

Misbehavior -> misbehaviour

c8f8212

Check for matching chain-ids

7536296

Merge remote-tracking branch 'origin/main' into hu55a1n1/12-misbehavi…

a37a67c

…our-handling

cargo update ci/no-std-check

c327d6d

hu55a1n1 added 17 commits November 24, 2022 17:24

Rename MisbehaviourConsensusStateTimestampGteTrustingPeriod

396c07f

-> ConsensusStateTimestampGteTrustingPeriod

Rename verify_misbehaviour_header_commit() -> verify_header_commit_ag…

ff2485d

…ainst_trusted()

Remove redundant client state expired check

017b34a

Impl Protobuf conversions for mock Misbehaviour

20dd6fd

Impl check_misbehaviour_and_update_state() for mock Misbehaviour

828eb3c

Merge remote-tracking branch 'origin/main' into hu55a1n1/12-misbehavi…

b217089

…our-handling

Merge remote-tracking branch 'origin/main' into hu55a1n1/12-misbehavi…

dbfe9bb

…our-handling

Remove cargo patches

e81877a

Fixes after tendermint-rs bump

dc8dbc6

Fix typo

3f69756

Add tests

3e8ef01

MockClientState::with_frozen_height()

f42d1a5

Provide MockContext helper to set client chain-id

f1e1ca6

Conversions from HostBlock -> TmLightBlock -> TmHeader

89fa046

Fix tests

7da7c58

Clippy fix

c92122a

Merge branch 'main' into hu55a1n1/12-misbehaviour-handling

ebdd644

ancazamfir reviewed Dec 2, 2022

View reviewed changes

crates/ibc/src/core/ics02_client/handler/misbehaviour.rs Show resolved Hide resolved

hu55a1n1 added 4 commits December 3, 2022 00:09

Cleanup tests

b29cfca

Add comments for tests

5fa7b52

Clippy fix

42a5c6b

Rustfmt

0780ad6

ancazamfir approved these changes Dec 5, 2022

View reviewed changes

hu55a1n1 merged commit f1ede0c into main Dec 5, 2022

hu55a1n1 deleted the hu55a1n1/12-misbehaviour-handling branch December 5, 2022 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misbehaviour handling implementation #215

Misbehaviour handling implementation #215

hu55a1n1 commented Nov 3, 2022 •

edited

Loading

hu55a1n1 commented Nov 7, 2022

ancazamfir left a comment

Misbehaviour handling implementation #215

Misbehaviour handling implementation #215

Conversation

hu55a1n1 commented Nov 3, 2022 • edited Loading

Description

PR author checklist:

Reviewer checklist:

hu55a1n1 commented Nov 7, 2022

ancazamfir left a comment

Choose a reason for hiding this comment

hu55a1n1 commented Nov 3, 2022 •

edited

Loading