Set counterparty_connection_id to None in conn_open_init #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
suggested changes
Nov 30, 2022
|
Just rebased and updated the changelog as requested. |
plafer
reviewed
Dec 1, 2022
|
Should be updated. |
7 tasks
plafer
added a commit
that referenced
this pull request
Dec 2, 2022
plafer
added a commit
that referenced
this pull request
Dec 6, 2022
…S-3) (#257) * `ConnOpenInit::validate` * conn_open_init: execute * conn_open_try `validate` and `execute` * conn_open_ack::validate * conn_open_ack::execute * conn_open_confirm::validate * conn_open_confirm::execute * changelog * LocalVars * validate_impl and execute_impl * Remove useless clone * fix ConnOpenInit::validate * fix conn_open_ack (as in #272) * conn_open_try: LocalVars * conn_open_try validate/execute impl * conn_open_ack LocalVars * conn_open_ack impl * Track code coverage with `cargo-llvm-cov` and codecov.io (#277) * Track code coverage with `cargo-llvm-cov` * Add changelog entry * Add coverage badge to the README * Misbehaviour handling implementation (#215) * Add ClientState::check_misbehaviour_and_update_state() * Implement misbehaviour handler * impl Protobuf<Any> for Misbehaviour * Remove redundant definition of decode_header() * Implement ChainId::with_version() * Getters for Tm Misbehaviour * Add missing checks for conversion from RawMisbehaviour * Make TmClientState::with_frozen_height() infallible * Implement TmClientState::check_misbehaviour_and_update_state() * Cleanup inner functions * Cleanup errors * Clippy fix * Ctor for TmMisbehaviour * Use git dependencies for tendermint crates * Add VerifyCommitLightTrusting check * Add VerifyCommit check * Clippy fix * Patch tendermint deps for no-std-check * Convert Tendermint VerificationError * Add helpers `Header::as_{un}trusted_block_state()` * Reorder untrusted verification logic * Reorder trusted verification logic * Misbehavior -> misbehaviour * Check for matching chain-ids * cargo update ci/no-std-check * Fix build failure after merge with main * Update for API changes in tm PR * Delete ci/no-std-check/Cargo.lock * Add changelog entry * Cleanup (naming & comments) * Rename check_trusted_header() -> check_header_validator_set() * Rename check_misbehaviour_header() -> check_header_and_validator_set() * Rename MisbehaviourConsensusStateTimestampGteTrustingPeriod -> ConsensusStateTimestampGteTrustingPeriod * Rename verify_misbehaviour_header_commit() -> verify_header_commit_against_trusted() * Remove redundant client state expired check * Impl Protobuf conversions for mock Misbehaviour * Impl check_misbehaviour_and_update_state() for mock Misbehaviour * Remove cargo patches * Fixes after tendermint-rs bump * Fix typo * Add tests * MockClientState::with_frozen_height() * Provide MockContext helper to set client chain-id * Conversions from HostBlock -> TmLightBlock -> TmHeader * Fix tests * Clippy fix * Cleanup tests * Add comments for tests * Clippy fix * Rustfmt * Fix wrong main branch name in code coverage job (#280) * implement `ValidationContext` for `MockContext` * conn_open_init: test validate() * Add `execute` entrypoint * re-export validate and execute * test validate() in connection handlers * Use into() instead of ContextError directly * reexport ContextError * fmt Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…S-3) (#257) * `ConnOpenInit::validate` * conn_open_init: execute * conn_open_try `validate` and `execute` * conn_open_ack::validate * conn_open_ack::execute * conn_open_confirm::validate * conn_open_confirm::execute * changelog * LocalVars * validate_impl and execute_impl * Remove useless clone * fix ConnOpenInit::validate * fix conn_open_ack (as in #272) * conn_open_try: LocalVars * conn_open_try validate/execute impl * conn_open_ack LocalVars * conn_open_ack impl * Track code coverage with `cargo-llvm-cov` and codecov.io (#277) * Track code coverage with `cargo-llvm-cov` * Add changelog entry * Add coverage badge to the README * Misbehaviour handling implementation (#215) * Add ClientState::check_misbehaviour_and_update_state() * Implement misbehaviour handler * impl Protobuf<Any> for Misbehaviour * Remove redundant definition of decode_header() * Implement ChainId::with_version() * Getters for Tm Misbehaviour * Add missing checks for conversion from RawMisbehaviour * Make TmClientState::with_frozen_height() infallible * Implement TmClientState::check_misbehaviour_and_update_state() * Cleanup inner functions * Cleanup errors * Clippy fix * Ctor for TmMisbehaviour * Use git dependencies for tendermint crates * Add VerifyCommitLightTrusting check * Add VerifyCommit check * Clippy fix * Patch tendermint deps for no-std-check * Convert Tendermint VerificationError * Add helpers `Header::as_{un}trusted_block_state()` * Reorder untrusted verification logic * Reorder trusted verification logic * Misbehavior -> misbehaviour * Check for matching chain-ids * cargo update ci/no-std-check * Fix build failure after merge with main * Update for API changes in tm PR * Delete ci/no-std-check/Cargo.lock * Add changelog entry * Cleanup (naming & comments) * Rename check_trusted_header() -> check_header_validator_set() * Rename check_misbehaviour_header() -> check_header_and_validator_set() * Rename MisbehaviourConsensusStateTimestampGteTrustingPeriod -> ConsensusStateTimestampGteTrustingPeriod * Rename verify_misbehaviour_header_commit() -> verify_header_commit_against_trusted() * Remove redundant client state expired check * Impl Protobuf conversions for mock Misbehaviour * Impl check_misbehaviour_and_update_state() for mock Misbehaviour * Remove cargo patches * Fixes after tendermint-rs bump * Fix typo * Add tests * MockClientState::with_frozen_height() * Provide MockContext helper to set client chain-id * Conversions from HostBlock -> TmLightBlock -> TmHeader * Fix tests * Clippy fix * Cleanup tests * Add comments for tests * Clippy fix * Rustfmt * Fix wrong main branch name in code coverage job (#280) * implement `ValidationContext` for `MockContext` * conn_open_init: test validate() * Add `execute` entrypoint * re-export validate and execute * test validate() in connection handlers * Use into() instead of ContextError directly * reexport ContextError * fmt Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #174
Closes: #274
Description
In addition to setting the connection ID to
Noneinconn_open_init, this PR also fixes a check inconn_open_ackthat expected the counterparty'sconnection_idto beSome(_)before the Ack message is processed.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.