Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f32/f64/usize in cosmwasm(and other no f32/f64 envs) reproduction and fixes #801

Closed
wants to merge 8 commits into from

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Aug 1, 2023

Closes: #800

Description

[nix-shell:~/github.com/cosmos/ibc-rs/ci/cw-check]$ cw-check
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /home/dz/github.com/cosmos/ibc-rs/ci/cw-check/Cargo.toml
workspace: /home/dz/github.com/cosmos/ibc-rs/Cargo.toml
   Compiling ibc v0.43.1 (/home/dz/github.com/cosmos/ibc-rs/crates/ibc)
   Compiling cw-check v0.1.0 (/home/dz/github.com/cosmos/ibc-rs/ci/cw-check)
    Finished release [optimized] target(s) in 4.85s
Available capabilities: {"cosmwasm_1_1", "iterator", "cosmwasm_1_2", "staking", "stargate"}

./target/wasm32-unknown-unknown/release/cw_check.wasm: pass

All contracts (1) passed checks!

[nix-shell:~/github.com/cosmos/ibc-rs/ci/cw-check]$ cw-check
   Compiling ibc v0.43.1 (/home/dz/github.com/cosmos/ibc-rs/crates/ibc)
   Compiling cw-check v0.1.0 (/home/dz/github.com/cosmos/ibc-rs/ci/cw-check)
    Finished release [optimized] target(s) in 7.30s
Available capabilities: {"staking", "cosmwasm_1_2", "iterator", "cosmwasm_1_1", "stargate"}

./target/wasm32-unknown-unknown/release/cw_check.wasm: failure
Error compiling Wasm: Could not compile: WebAssembly translation error: Error in middleware Gatekeeper: Float operator detected: F64Load { memarg: MemoryImmediate { align: 3, offset: 8, memory: 0 } }. The use of floats is not supported.

Passes: 0, failures: 1

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Farhad-Shabani and others added 7 commits July 27, 2023 15:25
…osmos#762)

* imp(ChainId): refactor abstraction and validations

* misc: add unclog

* fix: clippy catches

* fix: revert ChainId definition + improve checks

* fix: set_revision_number
* support for optional json schema

* some comment about using json schema

* more schema

* prefixed denom schema and amount fixes

* final transfer things

* release note

* connection is needed too

* std is for schema

* fixed de of u256

* tests behind flag

* clean up
…eld (cosmos#793)

* test: include deserialization test for no memo condition

* deps: bump ibc-proto-rs version
…#794)

* Add serde serialization and deserialization to PacketMsgType

* Create 794-add-ser-der-for-packet-receipt.md
* bump ibc-derive version to 0.2.0

* bump ibc version to v0.43.1

* dep: fetch ibc-derive from crates-io

* bump ibc-derive version
@dzmitry-lahoda dzmitry-lahoda marked this pull request as draft August 1, 2023 11:53
@dzmitry-lahoda dzmitry-lahoda changed the title #draft #wip f32/f64 in cosmwasm reproduction and fixes f32/f64/usize in cosmwasm(and other no f32/f64 envs) reproduction and fixes Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not use f64/f32/usize as it fails some wasm runtimes (cosmwasm)
3 participants