Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in mbt, do not set outstandingDowntime for double-sign slashes #1742

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

p-offtermatt
Copy link
Contributor

Description

Closes: MBT test failure in https://github.com/cosmos/interchain-security/actions/runs/8472508023/job/23214757156?pr=1740

The issue occurred if there was first a double-sign slash request and then a downtime slash request for the same node.
In the model, I mistakenly always put outstandingDowntime for the node to true, so the downtime slash request was not sent.

This PR fixes this and adds a test for the issue.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@p-offtermatt p-offtermatt marked this pull request as ready for review April 2, 2024 09:24
@p-offtermatt p-offtermatt requested a review from a team as a code owner April 2, 2024 09:24
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Apr 2, 2024
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@p-offtermatt p-offtermatt added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 2896f73 Apr 2, 2024
13 checks passed
@p-offtermatt p-offtermatt deleted the ph/mbt-fix-downtime branch April 2, 2024 12:58
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
…1742)

Fix: in mbt, do not set outstandingDowntime for double-sign slashes
(cherry picked from commit 2896f73)
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
…1742)

Fix: in mbt, do not set outstandingDowntime for double-sign slashes
(cherry picked from commit 2896f73)
mpoke pushed a commit that referenced this pull request Apr 2, 2024
…backport #1742) (#1747)

fix: in mbt, do not set outstandingDowntime for double-sign slashes (#1742)

Fix: in mbt, do not set outstandingDowntime for double-sign slashes
(cherry picked from commit 2896f73)

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
mpoke pushed a commit that referenced this pull request Apr 2, 2024
…backport #1742) (#1748)

fix: in mbt, do not set outstandingDowntime for double-sign slashes (#1742)

Fix: in mbt, do not set outstandingDowntime for double-sign slashes
(cherry picked from commit 2896f73)

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants