Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in mbt, do not set outstandingDowntime for double-sign slashes (backport #1742) #1748

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 2, 2024

Description

Closes: MBT test failure in https://github.com/cosmos/interchain-security/actions/runs/8472508023/job/23214757156?pr=1740

The issue occurred if there was first a double-sign slash request and then a downtime slash request for the same node.
In the model, I mistakenly always put outstandingDowntime for the node to true, so the downtime slash request was not sent.

This PR fixes this and adds a test for the issue.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

This is an automatic backport of pull request #1742 done by [Mergify](https://mergify.com).

…1742)

Fix: in mbt, do not set outstandingDowntime for double-sign slashes
(cherry picked from commit 2896f73)
@mergify mergify bot requested a review from a team as a code owner April 2, 2024 16:20
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Apr 2, 2024
@mpoke mpoke merged commit 9c22abe into release/v4.1.x-lsm Apr 2, 2024
13 checks passed
@mpoke mpoke deleted the mergify/bp/release/v4.1.x-lsm/pr-1742 branch April 2, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants