Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Added support for Nano S Plus #4

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

gjermundgaraba
Copy link

I recently got the new Ledger Nano S Plus, but it doesn't work for CLI clients made by the Cosmos SDK. I tracked the problem here and tested this on the Regen chain with great success.

If there is another route preferred to add support for this (for instance by updating this repo to match upstream and making the change there), let me know (although that would also require changes in ledger-cosmos-go).

@Chiccamandragora
Copy link

Hi, I can't use nano s plus with wasabi wallet, but I'd like to use it.
Do you know if there is a way to do it?

@philipglazman
Copy link

Tested locally on the new Ledger device and works as expected. Would be great to get this merged to fix upstream dependents.

@ainhoa-a ainhoa-a mentioned this pull request Jul 21, 2022
24 tasks
@ftheirs ftheirs merged commit 52ff0c8 into cosmos:master Jul 21, 2022
@okwme
Copy link

okwme commented Jul 25, 2022

great to see this merged!
will there be a new release @jleni or should we just target the commit in main?

@okwme
Copy link

okwme commented Aug 1, 2022

hello @jleni just following up here

@ftheirs
Copy link

ftheirs commented Aug 1, 2022

Hi @okwme, I apologize for the delay! The release was created! 🎉

@okwme
Copy link

okwme commented Aug 2, 2022

thank you @ftheirs !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants