fix: [v2.0] use a new version of cosmos/ledger-go for Ledger Nano S+
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjoon-lee
changed the title
youngjoon-lee
changed the title
cosmos/ledger-go for Ledger Nano S+
youngjoon-lee
changed the title
cosmos/ledger-go for Ledger Nano S+cosmos/ledger-go for Ledger Nano S+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the
v2.0branch.The
cosmos-sdkuses theledger-gov0.11.1 which doesn't support Ledger Nano S+ (A newly released device).Fortunately, the Cosmos team made a fix for
ledger-goa week ago: cosmos/ledger-go#4, and they are working on applying a new version ofledger-goto theircosmos-sdk. Until then, let's use a new version ofledger-godirectly in thepanacea-core.This fix will be released as v2.0.4 so that the Ledger team can continue their app review process. But, it's not mandatory to upgrade our mainnet to v2.0.4 since this fix affects to only
panacead ... --ledgercommands.I'll also apply this fix to the
masterbranch.