-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --jvm-index
#465
Conversation
I updated the dist using the same node version and commands like in your workflows (I do have setup-action/.github/workflows/update-dist.yml Lines 13 to 18 in 6a582d7
|
It works!
Would it be possible to get this merged and released with 1.3.5? Would be great, thanks! |
Anyone? |
Looks good to me, though would love the opinion of @alexarchambault just to be sure. If Alex doesn't have time I will try to look further and maybe merge next week. |
@tgodzik Great, thanks! |
This reverts commit 72fd656.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @mkurz!
I reverted the commit updating the dist files, as this is not needed (these are updated before tests on the CI, and pushed as a commit when on the main
branch)
@alexarchambault @tgodzik Can you please move the |
@mkurz That slipped my attention, should be fine now |
Thanks! |
…n/typescript-eslint/parser-7.1.0 build(deps-dev): bump @typescript-eslint/parser from 7.0.1 to 7.1.0
I set up a custom coursier index file that containts Java 21 (and soon newer) early access builds:
cs java --available --jvm-index https://github.com/mkurz/jvm-index/raw/adoptium_temurin_eaps/index.json
(If you are interested it was done with this hacked commit so you can generate the json file yourself locally if you want).
Reason is I want to run tests for the Play Framework with upcoming Java 21 LTS first release candidate (which is ea build 35) with our GitHub actions workflows. To set my index it needs support in your action.
Thanks!