Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9.x] We are testing upcoming JDK versions here #11925

Closed
wants to merge 4 commits into from

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Aug 19, 2023

I want to use this PR to test upcoming JDKs, so I will keep it open "forever" and just push to it from time to time.


I set up a custom coursier index file that containts Java 21 (and soon newer) early access builds (because the default coursier index does not contain any):

(If you are interested it was done with this hacked commit so you can generate the json file yourself locally if you want)

You can access the index file yourself and use it if you want:

$ cs java --available --jvm-index https://github.com/mkurz/jvm-index/raw/adoptium_temurin_eaps/index.json
adoptium:1.21-ea26
adoptium:1.21-ea27
adoptium:1.21-ea28
adoptium:1.21-ea29
adoptium:1.21-ea30
adoptium:1.21-ea31
adoptium:1.21-ea32
adoptium:1.21-ea33
adoptium:1.21-ea34

Currently build 35 is the first release candidate for Java 21 LTS, see the announcement in the mailing list.

To make this work I needed to add the jvm-index argument to the coursier/setup-action workflow:

And of course we need to then integrate that argument into our repo workflows as well:

@mkurz mkurz force-pushed the jdk-unstable-testing branch 2 times, most recently from 90871e4 to f33bf71 Compare August 19, 2023 16:09
@mkurz
Copy link
Member Author

mkurz commented Aug 19, 2023

All tests pass with JDK 21 🎉 ! IMHO it's safe to say we can officially support it for the 2.9 release. There will be another JDK21 release candidate (the last one) end of next week, I will then test as well, to make it 100% sure.
Ah, of course the only gotcha is the self signed certifacte stuff is not working in Java 21 anymore:

Not sure if for development purposes this is really relevant for the majority. Java 17 still works with it so not too bad.

@mkurz mkurz force-pushed the jdk-unstable-testing branch 2 times, most recently from eafd4d0 to c653480 Compare September 28, 2023 17:56
@mkurz mkurz changed the base branch from main to 2.9.x October 25, 2023 12:25
@mkurz mkurz changed the title We are testing upcoming JDK versions here [2.9.x] We are testing upcoming JDK versions here Oct 25, 2023
@mkurz mkurz closed this Oct 25, 2023
@mkurz mkurz reopened this Oct 25, 2023
@@ -156,21 +143,15 @@ jobs:
- "publish-local"
uses: playframework/.github/.github/workflows/cmd.yml@v3
with:
java: 17, 11
java: 21-ea34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's jdk 21 anyway 😉 Actually I want to set up Java 21 normally in our normal "check" workflow of course.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz mkurz force-pushed the jdk-unstable-testing branch 2 times, most recently from a0b4a61 to 4f8648a Compare February 27, 2024 12:57
@mkurz mkurz mentioned this pull request Feb 28, 2024
@mkurz
Copy link
Member Author

mkurz commented May 28, 2024

@mkurz mkurz closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants