-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.9.x] We are testing upcoming JDK versions here #11925
Conversation
90871e4
to
f33bf71
Compare
All tests pass with JDK 21 🎉 ! IMHO it's safe to say we can officially support it for the 2.9 release. There will be another JDK21 release candidate (the last one) end of next week, I will then test as well, to make it 100% sure.
Not sure if for development purposes this is really relevant for the majority. Java 17 still works with it so not too bad. |
f33bf71
to
0674f36
Compare
eafd4d0
to
c653480
Compare
c653480
to
c228d6d
Compare
@@ -156,21 +143,15 @@ jobs: | |||
- "publish-local" | |||
uses: playframework/.github/.github/workflows/cmd.yml@v3 | |||
with: | |||
java: 17, 11 | |||
java: 21-ea34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21.0.1
released yesterday 😉
https://github.com/adoptium/temurin21-binaries/releases/tag/jdk-21.0.1%2B12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's jdk 21 anyway 😉 Actually I want to set up Java 21 normally in our normal "check" workflow of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c228d6d
to
51e2121
Compare
a0b4a61
to
4f8648a
Compare
4f8648a
to
ee6ec23
Compare
|
I want to use this PR to test upcoming JDKs, so I will keep it open "forever" and just push to it from time to time.
I set up a custom coursier index file that containts Java 21 (and soon newer) early access builds (because the default coursier index does not contain any):
(If you are interested it was done with this hacked commit so you can generate the json file yourself locally if you want)
You can access the index file yourself and use it if you want:
Currently build 35 is the first release candidate for Java 21 LTS, see the announcement in the mailing list.
To make this work I needed to add the
jvm-index
argument to the coursier/setup-action workflow:--jvm-index
coursier/setup-action#465And of course we need to then integrate that argument into our repo workflows as well: