Skip to content

Commit

Permalink
chore(quantic): octokit rule for quantic removed from renovate (#3853)
Browse files Browse the repository at this point in the history
## [SFINT-5436](https://coveord.atlassian.net/browse/SFINT-5436)

This rule was previously added because a new major version of
`@octokit/graphql` broke our implantation in Quantic script that uses
this dependency.
This turned out to be an issue from their side that was fixed shortly
after that new major version :
octokit/graphql.js#551

Plus this renovate rules were containing a typo in the library name that
prevented the rule from doing its job properly.
we had `"matchPackagePatterns": ["^@otokit/graphql$"],` instead of
`"matchPackagePatterns": ["^@octokit/graphql$"],`

thus this dependency has been already updated by renovate to the latest
version as you can see here:
https://github.com/coveo/ui-kit/blob/1b28010482d0c88daf64aa98dae12f9a94a85c11/packages/quantic/package.json#L61-L62

[SFINT-5436]:
https://coveord.atlassian.net/browse/SFINT-5436?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Sylvie Allain <58052881+sallainCoveo@users.noreply.github.com>
  • Loading branch information
mmitiche and sallainCoveo authored Apr 26, 2024
1 parent 946d4e4 commit 0840fa1
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -144,22 +144,6 @@
"allowedVersions": "3.x",
"description": "sfdx-lwc-jest uses a not GA version of Salesforce API (60)"
},
{
"matchFileNames": ["packages/quantic/package.json"],
"matchPackagePatterns": ["^@otokit/graphql$"],
"groupSlug": "quantic-octokit-graphql",
"rangeStrategy": "replace",
"allowedVersions": "7.x",
"description": "8+ is ESM SFINT-5436"
},
{
"matchFileNames": ["packages/quantic/package.json"],
"matchPackagePatterns": ["^@otokit/graphql-schema$"],
"groupSlug": "quantic-octokit-graphql-schema",
"rangeStrategy": "replace",
"allowedVersions": "14.x",
"description": "15+ is ESM SFINT-5436"
},
{
"matchPackagePatterns": ["^actions/upload-artifact$"],
"groupSlug": "actions-upload-artifact",
Expand Down

0 comments on commit 0840fa1

Please sign in to comment.