fix(pkg): add main entry point
#551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
|
🎉 This PR is included in version 8.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
github-merge-queue bot
pushed a commit
to coveo/ui-kit
that referenced
this pull request
Apr 26, 2024
## [SFINT-5436](https://coveord.atlassian.net/browse/SFINT-5436) This rule was previously added because a new major version of `@octokit/graphql` broke our implantation in Quantic script that uses this dependency. This turned out to be an issue from their side that was fixed shortly after that new major version : octokit/graphql.js#551 Plus this renovate rules were containing a typo in the library name that prevented the rule from doing its job properly. we had `"matchPackagePatterns": ["^@otokit/graphql$"],` instead of `"matchPackagePatterns": ["^@octokit/graphql$"],` thus this dependency has been already updated by renovate to the latest version as you can see here: https://github.com/coveo/ui-kit/blob/1b28010482d0c88daf64aa98dae12f9a94a85c11/packages/quantic/package.json#L61-L62 [SFINT-5436]: https://coveord.atlassian.net/browse/SFINT-5436?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Sylvie Allain <58052881+sallainCoveo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tools don't play well with only having the
exportsfield present.See octokit/core.js#662