-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake has now deprecated support for versions prior to 3.5 #685
Comments
I'm in favor of this proposal. Could you create a Pull-Request for me to review and merge? But I'd even push the actual minimum required version to 3.5 |
* Minimum cmake version required now 3.5 Replace all "cmake_minimum_required" for cmake versions with 3.5 with 3.5 itself - reflecting soon to be the minimum version that cmake supports. * Minimum cmake version required in PR template now 3.5 too * Update cmake.rst in documentation Remove general references for cmake prior to 3.5 except for pure history comment. --------- Co-authored-by: NeroBurner <pyro4hell@gmail.com>
Fixed with Release: https://github.com/cpp-pm/hunter/releases/tag/v0.25.0 |
I believe that https://github.com/cpp-pm/gate/blob/master/cmake/HunterGate.cmake should be also updated to 3.5, right? |
It doesn't issue a deprecation warning as is fixed here, but to be thorough yes, this should also be updated. Wanna open a PR and ping me over there? |
will do 👍 |
cmake 3.27 has now deprecated support for versions prior to 3.5 but hunter is littered with minimum required statements such as:
cmake_minimum_required(VERSION 3.0)
The effect of this with the latest release is to have lots of warnings along the lines of (when configuring with hunter):
Things are still working: this is just a warning and the what is effectively a compatibility mode with 3.0 is still working, albeit
rather noisily. However the warnings are annoying (you get multiple ones per build) and do hint of a larger issue in the
near(?) future when the support is actually removed. At that point (based on what happened when earliest minimum
support went up last time) there will still be a warning but, instead of acting in (say) 3.0 compatibility mode, cmake will
act in 3.5 - assuming you are not actually using cmake that ancient.
The obvious thing to do would be to place all
cmake_minimum_required
within hunter, where the min is less that 3.5, with something like:With any cmake version after 3.12, this would run in 3.5 compatibility-mode instead of 3.0. If that does not work then it
would need fixing.
The text was updated successfully, but these errors were encountered: