#685 Minimum cmake version required now 3.5 #689
Conversation
Replace all "cmake_minimum_required" for cmake versions with 3.5 with 3.5 itself - reflecting soon to be the minimum version that cmake supports.
|
Note that I'm not sure how much testing is done by CI on this but I've had to answer "no" to the question on the PR as to "does this work with cmake 3.2" but I am wondering if that question is merely out of date. |
There was a problem hiding this comment.
Looking good. Just one blocking thing: please add a mention about the minimum version increase in https://hunter.readthedocs.io/en/latest/quick-start/cmake.html
ah yes: please update https://github.com/cpp-pm/hunter/blob/master/.github/PULL_REQUEST_TEMPLATE.md as well to require CMake 3.5 |
john-forrest
changed the title
Remove general references for cmake prior to 3.5 except for pure history comment.
|
@NeroBurner requested changes done |
Co-authored-by: NeroBurner <pyro4hell@gmail.com>
There was a problem hiding this comment.
Looking good.
@rbsheth please merge. I'll do a minor version bumped release afterwards
|
Oh cool! I could merge! I thought it wouldn't work because of the nor run set-status pipeline. I'm gonna wait a bit to give @rbsheth time to respond |
|
LGTM! |
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Replace all "cmake_minimum_required" for cmake versions prior to 3.5 with 3.5 itself - reflecting soon to be the minimum version that cmake supports.
This relates to Issue #685