Hard-code the original Cobra help template #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobra 1.6 has modified the default help template to support grouping. This breaks the logic in cobrautils which manipulates that help string. This commit hard-codes the original cobra help string instead of obtaining it from Cobra. This allows cobrautils to continue working as before for older versions of Cobra or newer ones. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
|
@cppforlife Any opinions on this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Cobra 1.6 has modified the default help template to support grouping. This breaks the logic in cobrautil which manipulates that help string.
This commit hard-codes the original cobra help string instead of obtaining it from Cobra. This allows cobrautil to continue working as before for older versions of Cobra or newer ones.