-
Notifications
You must be signed in to change notification settings - Fork 194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, assuming CI checks out
Cluster Generation A/B Results: |
This just needs the |
Let's get #3699 in first if we can |
Sure, let's wait. No particular hurry for the Cobra upgrade. |
ea702a6
to
bb5093f
Compare
I've updated the PR to move to Cobra 1.6.1 instead of 1.6.0 which was released yesterday |
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3695 +/- ##
==========================================
- Coverage 46.93% 46.03% -0.91%
==========================================
Files 402 427 +25
Lines 40203 41754 +1551
==========================================
+ Hits 18869 19221 +352
- Misses 19582 20765 +1183
- Partials 1752 1768 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for updating this.
bb5093f
to
9d18403
Compare
Cluster Generation A/B Results: |
9d18403
to
573d6bc
Compare
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But need to make sure all CI pipelines are successful before we merge this.
Looks like some unit tests are failing as part of Main/Build CI
|
Wow, thanks for finding this. I will look into it. |
So Framework's |
We don't upgrade the 'package' plugin however, because it uses github.com/vmware-tanzu/carvel-kapp-controller/cli/pkg/kctrl/cmd which in turn uses github.com/cppforlife/cobrautil which panics when using Cobra 1.6. See cppforlife/cobrautil#7 Signed-off-by: Marc Khouzam <kmarc@vmware.com>
573d6bc
to
53aee7e
Compare
Cluster Generation A/B Results: |
I've made the CI pass by not bumping cobra for the However, I am concerned that another plugin may have a similar problem, but that it is not triggered by CI. I have posted a PR to fix |
What this PR does / why we need it
This PR bumps to Cobra 1.6.1 which was recently released: https://github.com/spf13/cobra/releases/tag/v1.6.1
There is nothing really major in this new release, but it does have bug fixes and a couple of new features. We should keep up to date.
Describe testing done for PR
Let CI run