Update terminology client to use url param #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
TahaAttari
commented
Jun 27, 2024
| @@ -54,13 +54,27 @@ void testR4UrlAndVersion() { | |||
|
|
|||
| // when the valueset has a version it should be in params | |||
| vs.setVersion(version); | |||
| client.expand(vs, authoritativeSource, new org.hl7.fhir.r4.model.Parameters(), username, password); | |||
| client.expand(vs, authoritativeSource, null, username, password); | |||
There was a problem hiding this comment.
these changes are to add a bit more coverage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
============================================
+ Coverage 62.02% 62.11% +0.08%
- Complexity 3558 3571 +13
============================================
Files 328 328
Lines 17603 17621 +18
Branches 2715 2715
============================================
+ Hits 10919 10946 +27
+ Misses 5472 5469 -3
+ Partials 1212 1206 -6 ☔ View full report in Codecov by Sentry. |
ibaisi
reviewed
Jun 28, 2024
| expansionParameters = new org.hl7.fhir.r4.model.Parameters(); | ||
| } | ||
| expansionParameters.addParameter("url", new org.hl7.fhir.r4.model.UriType(url)); | ||
| expansionParameters.addParameter("valueSetVersion", new org.hl7.fhir.r4.model.StringType(version)); |
There was a problem hiding this comment.
maybe extract valueSetVersion to a const as it's used in many places?
barhodes
requested changes
Jul 2, 2024
|
superseded by #488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.