-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update terminology client to use url param #488
Merged
barhodes
merged 2 commits into
package-operation-updates
from
update-terminology-client-to-not-need-valueset
Jul 3, 2024
Merged
Update terminology client to use url param #488
barhodes
merged 2 commits into
package-operation-updates
from
update-terminology-client-to-not-need-valueset
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting check succeeded! |
TahaAttari
changed the title
add method to client without valueset
Update terminology client to use url param
Jul 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## package-operation-updates #488 +/- ##
===============================================================
+ Coverage 63.13% 63.20% +0.06%
- Complexity 3518 3528 +10
===============================================================
Files 342 342
Lines 16982 17000 +18
Branches 2661 2662 +1
===============================================================
+ Hits 10722 10744 +22
+ Misses 5096 5088 -8
- Partials 1164 1168 +4 ☔ View full report in Codecov by Sentry. |
barhodes
approved these changes
Jul 3, 2024
barhodes
added a commit
that referenced
this pull request
Aug 15, 2024
* Remove non CRMI logic. Update PackageProcessor to use visitor. * Add adapters for Questionnaire and StructureDefinition * Shortening some class names * Add type and dataRequirement * Refactor ValueSet expansion * Extract expansion logic out of PackageVisitor * Add tests * Fix class name * clean up adapters * stop expecting getRelatedArtifacts to pass a mutable ref * Enable test * Add tests * Add tests * Update terminology client to use url param (#488) * add method to client without valueset * spotless --------- Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com> * Add tests * Fix test * shorter * Add test * cleanup * cleanup * Questionnaire and StructureDefinition adapter work and DSTU3 extension support * spotless * add tests * add tests * cleanup and add tests * add tests * cleanup and tests * cleanup * add tests * spotless * add tests * Add MeasureAdapter * fix method signatures * Add tests * add tests * Add dependency tracing logic to MeasureAdapters * add tests * add tests --------- Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com> Co-authored-by: Taha <TahaAttari@users.noreply.github.com>
barhodes
added a commit
that referenced
this pull request
Aug 16, 2024
* Remove non CRMI logic. Update PackageProcessor to use visitor. * Add adapters for Questionnaire and StructureDefinition * Shortening some class names * Add type and dataRequirement * Refactor ValueSet expansion * Extract expansion logic out of PackageVisitor * Add tests * Fix class name * clean up adapters * stop expecting getRelatedArtifacts to pass a mutable ref * Enable test * Add tests * Add tests * Update terminology client to use url param (#488) * add method to client without valueset * spotless --------- Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com> * Add tests * Fix test * shorter * Add test * cleanup * cleanup * #494: Added measure support for the release operation * Questionnaire and StructureDefinition adapter work and DSTU3 extension support * spotless * add tests * add support for cqf-resourceType extension * fix Javadoc * typo * add MeasureAdapters * refactor to completely separate component and dependency resolution - moved component reference updates into internalRelease - created a dedicated resource cache for dependency resolution so it wouldn't get mixed up with the released resources - updated tests with newly found dependencies * remove isEmpty() * cleanup - make sure everything which can get a descriptor gets one - update var names and comments * check the expansion parameters for dependency versions * update expansion parameters with new values * update tests * spotless * update Measure Test, check descriptors are set correctly, expansion parameters test pending * remove unsupported * check exp params, data requirements and resource type extensions * spotless * update tests to increase coverage and handle edge cases * remove extension generic * spotless * looks like HAPI auto prepends # to contained IDs * cleanup * add hash to id * more hash issues * add tests * cleanup and add tests * add tests * cleanup and tests * cleanup * add tests * spotless * add tests * Add MeasureAdapter * fix method signatures * Add tests * add tests * Add dependency tracing logic to MeasureAdapters * remove unnecessary methods * update adapters * add tests * fix merge issues * remove old constants * update tests * update tests * spotless * update tests and cqfm vs crmi edr * spotless * cleanup and tests --------- Co-authored-by: Brenin Rhodes <brenin@alphora.com> Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com> Co-authored-by: Bryn Rhodes <bryn@databaseconsultinggroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.