Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataRequrementsProcessor from cqframework elm #340

Merged
merged 10 commits into from
Oct 26, 2021

Conversation

mdnazmulkarim
Copy link
Contributor

updated in the $data-requirements operation to use DataRequrementsProcessor from cqframework elm

@JPercival
Copy link
Contributor

Since we have to transform to/from R5 in order to support the datarequirements, we should probably make the DataRequirementsProvider R5 only, and then add the mapping code to the respective Operation providers.

@JPercival
Copy link
Contributor

Also, we need this code for dstu3 as well.

@mdnazmulkarim mdnazmulkarim marked this pull request as ready for review September 30, 2021 21:18
Copy link
Contributor

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@sliver007 sliver007 dismissed JPercival’s stale review October 26, 2021 18:53

No time to review the requested changes and need to get it merged.

@sliver007 sliver007 merged commit 4e36c3a into master Oct 26, 2021
@sliver007 sliver007 deleted the data-requirements-use-translator branch October 26, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants