Merge pull request #1390 from craftcms/bugfix/1387-entries-field-reta…

…in-selected-entry-type mapping page, entries field - retain selected type id
craftcms · Feb 26, 2024 · 2166508 · 2166508
2 parents 4f39d42 + ef89ada
commit 2166508
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/src/templates/_includes/fields/entries.html b/src/templates/_includes/fields/entries.html
@@ -98,13 +98,14 @@
             {% endfor %}
 
             {% if sources and sources[0] %}
-                <div class="element-group element-group-entrytype" data-items="{{ entryTypes|json_encode }}">
+                {% set selectedTypeId = hash_get(feed.fieldMapping, optionsPath ~ '.group.typeId') ?: '' %}
+                <div class="element-group element-group-entrytype" data-items="{{ entryTypes|json_encode }}" data-selectedTypeId="{{ selectedTypeId }}">
                     <span>{{ 'Type:'|t('feed-me') }}</span>
 
                     {{ forms.selectField({
                         name: 'options[group][typeId]',
                         class: '',
-                        value: hash_get(feed.fieldMapping, optionsPath ~ '.group.typeId') ?: '',
+                        value: selectedTypeId,
                         options: entryTypes['item_' ~ sources[0].id] ?? [],
                     }) }}
                 </div>

diff --git a/src/web/assets/feedme/dist/FeedMe.js b/src/web/assets/feedme/dist/FeedMe.js
diff --git a/src/web/assets/feedme/dist/FeedMe.js.map b/src/web/assets/feedme/dist/FeedMe.js.map
diff --git a/src/web/assets/feedme/src/js/feed-me.js b/src/web/assets/feedme/src/js/feed-me.js
@@ -191,6 +191,7 @@ $(function () {
         .parents('.field-extra-settings')
         .find('.element-group-entrytype');
       var sections = $container.data('items');
+      var selectedTypeId = $container.data('selectedtypeid');
 
       // var sections = $(this).parents('.element-sub-group').data('items');
       var entryType = 'item_' + $(this).val();
@@ -199,7 +200,14 @@ $(function () {
       var newOptions = '';
       $.each(entryTypes, function (index, value) {
         if (index) {
-          newOptions += '<option value="' + index + '">' + value + '</option>';
+          newOptions +=
+            '<option value="' +
+            index +
+            '"' +
+            (index == selectedTypeId ? ' selected="selected"' : '') +
+            '>' +
+            value +
+            '</option>';
         }
       });