Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapping page, entries field - retain selected type id #1390

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Dec 6, 2023

Description

On the mapping screen, for the entries field - retain the selected entry type (for “Create entries if they do not exist”) on page reload.

For v4 and v5. Brad - LMK if it doesn't want to merge cleanly, and I can quickly create a separate PR for v5.

Related issues

#1387

@i-just i-just requested a review from angrybrad as a code owner December 6, 2023 13:47
@flimshaw
Copy link

flimshaw commented Feb 7, 2024

I wasn't able to import this directly in composer because of some complaining about versions, but just pasting in the new JS and TWIG and npm building fixes my problems locally!

Getting this fix in would really help us out a lot

@angrybrad angrybrad merged commit 2166508 into v4 Feb 26, 2024
5 checks passed
@angrybrad angrybrad deleted the bugfix/1387-entries-field-retain-selected-entry-type branch February 26, 2024 01:04
angrybrad added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants