Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Set up Google analytics #88

Merged
merged 4 commits into from
Feb 4, 2020
Merged

[WIP] Set up Google analytics #88

merged 4 commits into from
Feb 4, 2020

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 28, 2020

Fixes #62 and #64

Description

Set up Google analytics for chooser. The following events are tracked:

  • User opening the page

  • User clicking on any of the 'Help' button
    Information sent: HelpSection.clicked.<button-title>

  • User opening Attribution Details step, when we can assume that the user has selected a license :
    Information sent: Stepper.licenseSelected.<short name of selected license>

  • User selecting a license from the dropdown
    Information sent: LicenseDropdown.licenseSelected.<short name of selected license>

  • User copying attribution details
    Information sent:
    Attribution.copied.<Stringified JSON: license: short name of selected license, codeType: one of html/rich-text, fieldsFilled: <fieldName: true/false>>

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat requested a review from akmadian January 28, 2020 12:01
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not getting to this sooner. Looks great so far! Some little things here and there, though

src/main.js Outdated Show resolved Hide resolved
src/components/Stepper.vue Outdated Show resolved Hide resolved
src/components/SelectedLicenseCode.vue Outdated Show resolved Hide resolved
@akmadian
Copy link
Member

akmadian commented Feb 3, 2020

Also, please add #64 to the "Fixes" line in your PR body

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Go ahead and merge whenever :)

@obulat
Copy link
Contributor Author

obulat commented Feb 4, 2020

Thank you, Ari, your changes made it much better :)

@obulat obulat merged commit c1170da into master Feb 4, 2020
@obulat obulat deleted the ga branch February 4, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Google Analytics
2 participants