-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] prettier
not installed correctly
#113
Comments
Same here, workflows using this actions randomly started failing recently with the same error |
Version 3.3 appears to be the latest version that is not affected. |
Here the same issue in multile repo's. |
A workaround for this bug: pin npm to version 8 in your job (if it's possible)
|
I've done some debugging:
ConclusionIt seems currently this action won't work with |
There's currently an issue (creyD/prettier_action#113) preventing the action from running properly on npm v9.
Hi all! Thanks for the quick and efficient coordination. As I can see you already worked out a workaround. I can also add it to the readme to support struggling users. Would it be a good idea to pin the npm version in the action? Or what ways forward should we think of? |
Alright, there is now v4.3 which has the bugfix and a note for the workaround in the readme. Thanks for everyone who hel'ped and supported here! All repos using the action with the |
See creyD/prettier_action#113, force-pushing to immediately unblock.
I think it's a good practice to pin versions when possible, so that the behavior will always be the same. Then when something gets an update, it can be manually updated on the action, making sure that everything's working as excepted |
https://github.com/creyD/prettier_action/releases/tag/v4.3 Workaround for issues with NPM v9: - creyD/prettier_action#113 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
We were bitten by creyD/prettier_action#113, which breaks our code style check and therefore our ability to submit PRs. The fix is to update that action to v4.3. And to yell and gesticulate wildly about how GitHub Actions shouldn't change the major version of the `npm` runtime without us taking action!
We were bitten by creyD/prettier_action#113, which breaks our code style check and therefore our ability to submit PRs. The fix is to update that action to v4.3. And to yell and gesticulate wildly about how GitHub Actions shouldn't change the major version of the `npm` runtime without us taking action!
https://github.com/creyD/prettier_action/releases/tag/v4.3 Workaround for issues with NPM v9: - creyD/prettier_action#113 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
* ci: errors on non-existent files * this should get formatted * without prettier_options * fix: creyD/prettier_action#113 * this should get formatted? * Prettified Code! --------- Co-authored-by: alexanderl19 <alexanderl19@users.noreply.github.com>
There was a bug in 4.2 (due to a NPM update) that prevented it from working: creyD/prettier_action#113
There was a bug in 4.2 (due to a NPM update) that prevented it from working: creyD/prettier_action#113
What exactly happened?
Our team is using this prettier action to format code on push to main. The action was working as of ~8h ago, but as of ~5h ago fails to install the
prettier
command correctly. No changes to our GitHub workflow were made and we've tried rerunning the workflow several times with the same result. We get:on action run.
Steps to reproduce the behavior:
What should've happened?
The Action should have correctly installed
prettier
.How did it look?
Full stack trace:
Where did you encounter the problem?
The text was updated successfully, but these errors were encountered: