Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the npm bin command to resolve the bin path #112

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

tropictim
Copy link
Contributor

This action is failing with the latest Ubuntu 22.04 image because npm updated to v9 which doesn't have the bin command. This change has fixed it for our repositories that are using the ubuntu image with npm v9

@junzhengca
Copy link

Having same issue with GitHub hosted runners.

Bumping this up so it gets reviewed :).

Copy link

@imovishek imovishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@Viicos
Copy link

Viicos commented Feb 18, 2023

Will fix #113

@andrashee
Copy link

Would be nice to merge this, to unblock PRs leveraging this action 👍

@creyD
Copy link
Owner

creyD commented Feb 19, 2023

Thanks a lot for the quick PR! I will try this real quick on dev and then merge it to master, probably with a new release.

@dongcheolpark

This comment was marked as resolved.

@Viicos
Copy link

Viicos commented Feb 20, 2023

@dongcheolpark Use v4.3 or the workaround described here

@dongcheolpark
Copy link

@dongcheolpark Use v4.3 or the workaround described here

I thought it was latest version.. thank you !!

@tropictim tropictim deleted the fix_path branch February 20, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants