Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI no longer supports wildcard matching, nor multiple --target specificiers. #815

Closed
Alexhuszagh opened this issue Jun 17, 2022 · 2 comments · Fixed by #816
Closed

CI no longer supports wildcard matching, nor multiple --target specificiers. #815

Alexhuszagh opened this issue Jun 17, 2022 · 2 comments · Fixed by #816
Labels
bug meta issues/PRs related to the maintenance of the crate. regression

Comments

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jun 17, 2022 •
edited
Loading

Trying bors try --target x86_64-unknown-linux-gnu* produces no targets in the matrix, nor does it seemingly support more than one target. This seems to be a regression related that undoes #744.
@Alexhuszagh Alexhuszagh added bug meta issues/PRs related to the maintenance of the crate. regression labels Jun 17, 2022
@Emilgardis
Copy link
Member

Yep, there is a missing test(q) in the query i think

@Alexhuszagh
Copy link
Contributor Author

Yep, there is a missing test(q) in the query i think

It should be if has(".sub") ..., not if .sub .... Working on this right now, it's still incomplete but almost ready. Currently doesn't work if the target query doesn't have a sub but the CI target does. Not sure if that's easy to fix, however.

Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 17, 2022
@Alexhuszagh
Fix wildcard and multiple selects.
116fad5 
Allows wildcard selects in target names, although not in subs.

Closes cross-rs#815.
@Alexhuszagh Alexhuszagh mentioned this issue Jun 17, 2022
Merged
bors bot added a commit that referenced this issue Jun 17, 2022
@bors @Alexhuszagh
Merge #816
0301a37 
816: Fix wildcard and multiple selects. r=Emilgardis a=Alexhuszagh

Allows wildcard selects in target names, although not in subs.
    
Closes #815.


Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
@bors bors bot closed this as completed in 57de6de Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug meta issues/PRs related to the maintenance of the crate. regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wildcard and multiple selects. Alexhuszagh/cross
2 participants
@Emilgardis @Alexhuszagh