Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple bors targets. #744

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

Alexhuszagh
Copy link
Contributor

Allow using bors try --target ... --target ..., allowing multiple arguments rather than just a single one.

@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 2, 2022 18:23
@Alexhuszagh
Copy link
Contributor Author

bors try --target thumbv7em-none-eabihf --target thumbv7m-none-eabi

@Alexhuszagh Alexhuszagh added the no changelog A valid PR without changelog (no-changelog) label Jun 2, 2022
@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

try

Build failed:

@Alexhuszagh Alexhuszagh force-pushed the ci_targets branch 2 times, most recently from bb2d3d7 to 04f8e38 Compare June 2, 2022 18:28
Allow using `bors try --target ... --target ...`, allowing multiple
arguments rather than just a single one.
otavio
otavio previously approved these changes Jun 2, 2022
@otavio
Copy link
Contributor

otavio commented Jun 2, 2022

I am not confortable with bors so I prefer someone else check if sounds good as well prior merging.

@Alexhuszagh
Copy link
Contributor Author

@otavio Let's wait for the bors try --target ... --target ... to pass before merging.

@Alexhuszagh
Copy link
Contributor Author

bors try --target thumbv7em-none-eabihf --target thumbv7m-none-eabi

@Emilgardis
Copy link
Member

I am not confortable with bors so I prefer someone else check if sounds good as well prior merging.

don't leave a approval if that is the case <3

@Alexhuszagh
Copy link
Contributor Author

Alexhuszagh commented Jun 2, 2022

Ok this properly builds only those two targets. This should also work for wildcards, since the syntax is '.[] | select(. == "*at")', which means we could provide --target armv7-* for all ARMv7 targets, or we could even select ARMv7 HF targets with --target armv7-*hf.

@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

try

Build succeeded:

.github/workflows/ci.yml Show resolved Hide resolved
@Emilgardis
Copy link
Member

bors try --target notarget

bors bot added a commit that referenced this pull request Jun 2, 2022
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

try

Build failed:

@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

Build succeeded:

@bors bors bot merged commit 87a322e into cross-rs:main Jun 2, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants