IAMPolicy #197
Merged
IAMPolicy #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
reviewed
Apr 21, 2020
sahil-lakhwani
force-pushed
the
iampolicy
branch
from
8b36d18 to
6fedab9
Compare
negz
requested changes
Apr 27, 2020
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
negz
requested changes
May 12, 2020
There was a problem hiding this comment.
Thanks @sahil-lakhwani! I've added one small suggestion that I'd like to address before I merge this.
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
negz
approved these changes
May 16, 2020
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this pull request
Feb 12, 2021
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds IAM Policy as a managed resource.
Example:
example/iam/policy.yamlThis PR depends on #194 & #196, and should not be merged before those
For the update case:
An update to the policy is actually creating a new version of that policy. The approach in this PR sets the latest version as the default version. Also, because only maximum of 5 versions are allowed, the oldest version is deleted for an update request when there are already 5 versions.
Checklist
I have:
make reviewableto ensure this PR is ready for review.app.yamlto include any new role permissions.