IAMUserPolicyAttachment #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
requested changes
Apr 22, 2020
|
|
||
| // UserName presents the name of the IAM user. | ||
| // +optional | ||
| UserName string `json:"userName,omitempty"` |
There was a problem hiding this comment.
This should be pointer type I believe.
| "github.com/crossplane/crossplane-runtime/pkg/resource" | ||
| ) | ||
|
|
||
| // UserNameReferencerForUserPolicyAttachment is an attribute referencer that retrieves Name from a referenced User |
There was a problem hiding this comment.
Referencer structure will need to be revised per pattern in #198
sahil-lakhwani
force-pushed
the
userpolicy
branch
from
c2e7613 to
0f42052
Compare
negz
approved these changes
Apr 27, 2020
apis/identity/v1alpha1/register.go
Outdated
| UserPolicyAttachmentKind = reflect.TypeOf(IAMUserPolicyAttachment{}).Name() | ||
| UserPolicyAttachmentGroupKind = schema.GroupKind{Group: Group, Kind: UserPolicyAttachmentKind}.String() | ||
| UserPolicyAttachmentKindAPIVersion = UserPolicyAttachmentKind + "." + SchemeGroupVersion.String() | ||
| UserPolicyAttachmentGroupVersionKind = SchemeGroupVersion.WithKind(UserPolicyAttachmentKind) |
There was a problem hiding this comment.
These should be IAMUserPolicyAttachment<X> to match the name of the struct.
sahil-lakhwani
force-pushed
the
userpolicy
branch
from
0f42052 to
0173be6
Compare
hasheddan
approved these changes
Apr 29, 2020
|
@sahil-lakhwani Could you please rebase this on master now that #194 is merged. Once you do so I'll merge this PR. |
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
…tachment' Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
sahil-lakhwani
force-pushed
the
userpolicy
branch
from
0173be6 to
4be7d8f
Compare
@negz I have update this branch with master |
Closed
26 tasks
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this pull request
Feb 12, 2021
IAMUserPolicyAttachment
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
IAMUserPolicyAttachment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds
UserPolicyAttachmentresource, which helps to attach IAM managed policy to an IAM user.This depends on (and is a checkout from) #194 and should not be merged before that
Example:
examples/iam/userpolicyattachment.yamlChecklist
I have:
make reviewableto ensure this PR is ready for review.app.yamlto include any new role permissions.