Migrate to simple reference selection and resolution #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nic Cope <negz@rk0n.org>
S3 buckets have no references, and are likely to be ported to v1beta1 before they do. Signed-off-by: Nic Cope <negz@rk0n.org>
|
Okay, this is ready for review. I've successfully tested all references by applying the updated cache, compute, and database examples included in this PR. |
This was referenced Apr 18, 2020
Merged
hasheddan
requested changes
Apr 18, 2020
Signed-off-by: Nic Cope <negz@rk0n.org>
This allows our examples to be more self contained, and exercise some of our network and IAM plumbing resources. Signed-off-by: Nic Cope <negz@rk0n.org>
|
@hasheddan I believe I've addressed your concerns - PTAL! |
hasheddan
approved these changes
Apr 20, 2020
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this pull request
Feb 12, 2021
Migrate to simple reference selection and resolution
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
Migrate to simple reference selection and resolution
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I've successfully tested all references by applying the updated cache, compute, and database examples included in this PR.
Checklist
I have:
make reviewableto ensure this PR is ready for review.app.yamlto include any new role permissions.