Fix panic when returning error with provider reference name #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a panic in the storage container controller that used the provider reference name in the error when we are unable to get the storage account that serves as this type's provider. The ProviderReference may be nil in the case that the newer ProviderConfigReference is used. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
commented
Nov 11, 2021
| @@ -331,6 +331,24 @@ func Test_containerSyncdeleterMaker_newSyncdeleter(t *testing.T) { | |||
| "failed to retrieve storage account: %s", testAccountName), | |||
| }, | |||
| }, | |||
| { | |||
| name: "FailedToGetAccountNotFoundNoDeleteProviderConfigRef", | |||
There was a problem hiding this comment.
This test panics without the updated error message.
Adds a unit test for the storage container reconciler to ensure that we do not panic on usage of providerConfigRef when the storage account is not found. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
no-panic-storage-container
branch
from
b7ec1bb
to
60e6860
Compare
negz
approved these changes
Nov 11, 2021
|
/backport |
|
Successfully created backport PR #303 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes a panic in the storage container controller that used the provider
reference name in the error when we are unable to get the storage
account that serves as this type's provider. The ProviderReference may
be nil in the case that the newer ProviderConfigReference is used.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #248
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have not tested this change extensively, but I have a high degree of confidence in the fix given the observed stack trace on panic:
I have also added a unit test that confirms that panic does occur prior to the change, and does not after.